Bugzilla – Attachment 10566 Details for
Bug 8175
items.materials check logs error or displays incorrectly in details.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Undefined $items->{'materials'} fails a string check, so drop it.
0001-Bug-8175-Missing-defined-check-in-catalogue-details..patch (text/plain), 897 bytes, created by
Mark Tompsett
on 2012-06-29 15:18:40 UTC
(
hide
)
Description:
Undefined $items->{'materials'} fails a string check, so drop it.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2012-06-29 15:18:40 UTC
Size:
897 bytes
patch
obsolete
>From e14d628790a55017832a0946b9d21556f3269ad9 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 29 Jun 2012 23:13:57 +0800 >Subject: [PATCH] Bug 8175 - Missing defined check in catalogue/details.pl > Actually, just dropping the "ne ''" was better. In some > cases $item->{'materials'} isn't defined. Any value is > true, so no need for comparison. >Content-Type: text/plain; charset="utf-8" > >--- > catalogue/detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index d110740..97ed167 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -261,7 +261,7 @@ foreach my $item (@items) { > $analytics_flag=1; > $item->{countanalytics} = $countanalytics; > } >- if ($item->{'materials'} ne ''){ >+ if ($item->{'materials'}){ > $materials_flag = 1; > } > push @itemloop, $item; >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8175
:
10566
|
10577
|
10620
|
11496
|
11937
|
11956