Bugzilla – Attachment 105680 Details for
Bug 25707
Mappings update in bug 11529 causes incorrect MARC to DB data flow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log
Bug-25707-bug-11529-follow-up-Do-not-update-marc-m.patch (text/plain), 2.04 KB, created by
Nick Clemens (kidclamp)
on 2020-06-10 10:08:39 UTC
(
hide
)
Description:
Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-06-10 10:08:39 UTC
Size:
2.04 KB
patch
obsolete
>From 1e0d6cd2fb4d8c1953b5a98a5907a092e235caf7 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 9 Jun 2020 12:49:54 -0400 >Subject: [PATCH] Bug 25707: (bug 11529 follow-up) Do not update marc > mappings, print old mappings to upgrade log > >This patch removes the update of marc frameworks from the updatedatabase script and warns the >"MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > installer/data/mysql/updatedatabase.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index b53146f873..10c7ac05ba 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -19229,8 +19229,8 @@ if( CheckVersion( $DBversion ) ) { > }); > } > >- $dbh->do("UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE fieldmapping.frameworkcode=''"); >- $sth = $dbh->prepare("SELECT * FROM fieldmapping WHERE frameworkcode != '' OR field != 'subtitle'"); >+# $dbh->do(q{UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE fieldmapping.frameworkcode='' AND field = 'subtitle'}); >+ $sth = $dbh->prepare("SELECT * FROM fieldmapping"); # WHERE frameworkcode != '' OR field != 'subtitle'"); > $sth->execute; > my @fails_11529; > if ( $sth->rows ) { >@@ -19259,7 +19259,7 @@ if( CheckVersion( $DBversion ) ) { > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 11529: Add medium, subtitle and part information to biblio table)\n"; > if ( @fails_11529 ) { >- print "WARNING: Not all Keyword to MARC mappings could be preserved\n"; >+ print "WARNING: Keyword to MARC Mappings:\n"; > for my $fail_11529 ( @fails_11529 ) { > print " keyword: " > . $fail_11529->{field} >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25707
:
105680
|
105771
|
105772