Attachment 105720 Details for Bug 25155 – Bug 25155: Fixing semantic headings in opac-auth.tt

[patch] Bug 25155: Fixing semantic headings in opac-auth.tt

Bug-25155-Fixing-semantic-headings-in-opac-authtt.patch (text/plain), 5.92 KB, created by Hayley Pelham on 2020-06-11 01:18:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hayley Pelham

Created: 2020-06-11 01:18:07 UTC

Size: 5.92 KB

patch

obsolete

>From 558555ed687f3272f89fd2e5131c904e182ceb3e Mon Sep 17 00:00:00 2001
>From: Hayley Mapley <hayleymapley@catalyst.net.nz>
>Date: Thu, 11 Jun 2020 13:13:30 +1200
>Subject: [PATCH] Bug 25155: Fixing semantic headings in opac-auth.tt
>
>Test plan:
>1) Follow test plan from comment #1
>2) Apply the patch
>3) Reload the page, and note that is still displays fine
>4) Check that the main heading is now an h1, and that the other headings
>on the page make sense
>---
> .../opac-tmpl/bootstrap/en/modules/opac-auth.tt    | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
>index bbd4c575777..30ec2bda0a2 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
>@@ -29,7 +29,7 @@
>                         [% IF ( nopermission ) %]
>                             
>                             <div class="alert">
>-                                <h3>Access denied</h3>
>+                                <h1>Access denied</h1>
>                                 <p>Sorry, the system doesn't think you have permission to access this page. </p>
>                                 [% IF SCO_login %]
>                                     <p><a href="/cgi-bin/koha/sco/sco-main.pl?logout.x=1">Log out and try again with a different user.</a></p>
>@@ -41,7 +41,7 @@
> 
>                         [% IF ( loginprompt ) %]
>                             
>-                            <h3>Log in to your account</h3>
>+                            <h1>Log in to your account</h1>
> 
>                             [% IF ( timed_out ) %]
>                                 
>@@ -82,14 +82,14 @@
>                                     [% END %]
>                                     </div>
>                             [% ELSE %]
>-                                <h4>Shibboleth Login</h4>
>+                                <h2>Shibboleth Login</h2>
>                                 <p><a href="[% shibbolethLoginUrl | $raw %]">If you have a Shibboleth account, please click here to log in.</a></p>
>                             [% END %]
>                             [% IF ( casAuthentication ) %]
>-                                <h4>CAS login</h4>
>+                                <h2>CAS login</h2>
>                                 <p>If you do not have a Shibboleth account, but you do have a CAS account, you can use CAS.</p>
>                             [% ELSE %]
>-                                <h4>Local login</h4>
>+                                <h2>Local login</h2>
>                                 <p>If you do not have a Shibboleth account, but you do have a local login, then you may login below.</p>
>                             [% END %]
> 
>@@ -110,7 +110,7 @@
>                                     </ul>
>                                 [% END %]
>                             [% ELSE %]
>-                                <h4>CAS login</h4>
>+                                <h2>CAS login</h2>
> 
>                                 [% IF ( invalidCasLogin ) %]
>                                     
>@@ -134,7 +134,7 @@
>                             [% IF ( shibbolethAuthentication ) %]
>                                 <p>Nothing</p>
>                             [% ELSE %]
>-                                <h4>Local login</h4>
>+                                <h2>Local login</h2>
>                                 <p>If you do not have a CAS account, but do have a local account, you can still log in: </p>
>                             [% END %]
> 
>@@ -142,7 +142,7 @@
> 
>                         [% IF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %]
>                             [% IF ( invalidGoogleOpenIDConnectLogin ) %]
>-                                <h4>Google login</h4>
>+                                <h2>Google login</h2>
>                                 <p>Sorry, your Google login failed. <span class="error">[% invalidGoogleOpenIDConnectLogin | html %]</span></p>
>                                 <p>Please note that the Google login will only work if you are using the e-mail address registered with this library.</p>
>                                 <p>If you want to, you can try to <a href="/cgi-bin/koha/svc/auth/googleopenidconnect?reauthenticate=select_account">log in using a different account</a>
>@@ -179,9 +179,9 @@
>                             [% IF Koha.Preference('OpacLoginInstructions') %]
>                                 [% Koha.Preference('OpacLoginInstructions') | $raw %]
>                             [% ELSE %]
>-                                <h5>Don't have a password yet?</h5>
>+                                <h2>Don't have a password yet?</h2>
>                                 <p>If you don't have a password yet, stop by the circulation desk the next time you're in the library. We'll happily set one up for you.</p>
>-                                <h5>Don't have a library card?</h5>
>+                                <h2>Don't have a library card?</h2>
>                                 <p>If you don't have a library card, stop by your local library to sign up.</p>
>                             [% END # / IF Koha.Preference('OpacLoginInstructions') %]
> 
>@@ -192,7 +192,7 @@
>                         [% END # / IF loginprompt %]
> 
>                     [% ELSE %]
>-                        <h4>Logging on to the catalog has not been enabled by the library.</h4>
>+                        <h1>Logging on to the catalog has not been enabled by the library.</h1>
>                         <ul>
>                             <li>To report this error, you can email the Koha Administrator.<a href="mailto:[% admin | uri %]">Email</a></li>
>                             <li>Use top menu bar to navigate to another part of Koha.</li>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25155: 105720 | 105722 | 105723 | 105724 | 105755 | 105756 | 105757 | 106618