Attachment 105723 Details for Bug 25155 – Bug 25155: Fixing semantic headings login modal

[patch] Bug 25155: Fixing semantic headings login modal

Bug-25155-Fixing-semantic-headings-login-modal.patch (text/plain), 2.50 KB, created by Martin Renvoize (ashimema) on 2020-06-11 09:16:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-06-11 09:16:22 UTC

Size: 2.50 KB

patch

obsolete

>From 58af1ec35b245b0286ad4d9d14e7cb93e1f7a4dc Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 11 Jun 2020 09:32:45 +0100
>Subject: [PATCH] Bug 25155: Fixing semantic headings login modal
>
>The login modal headings were semantically incorrect prior to this
>patch.
>
>Test plan:
>1) Click the 'Log in to your account' option to expose the modal
>2) Use a headings inspector and note we jump from H1 (Page Title) -> H3
>   (Modal Title)
>3) Apply the patch and reload the page.
>4) Click the 'Log in to your account' option to expose the modal
>5) The modal should still appear well formed
>6) Use a headings inspector and note we jump from H1 (Page Title) -> H2
>   (Modal Title) -> H3 (Shibboleth title if enabled)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index 88dd9a9255..3b3cab72bb 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -335,7 +335,7 @@
>     <div id="loginModal" class="modal hide" tabindex="-1" role="dialog" aria-labelledby="modalLoginLabel" aria-hidden="true">
>         <div class="modal-header">
>             <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">Ã</button>
>-            <h3 id="modalLoginLabel">Log in to your account</h3>
>+            <h2 id="modalLoginLabel">Log in to your account</h2>
>         </div>
>         <form action="/cgi-bin/koha/opac-user.pl" method="post" name="auth" id="modalAuth">
>             <input type="hidden" name="has-search-query" id="has-search-query" value="" />
>@@ -347,9 +347,9 @@
>                             <p>Sorry, your Shibboleth identity does not match a valid library identity. If you have a local login, you may use that below.</p>
>                         </div>
>                     [% ELSE %]
>-                        <h4>Shibboleth login</h4>
>+                        <h3>Shibboleth login</h3>
>                         <p>If you have a Shibboleth account, please <a href="[% shibbolethLoginUrl | $raw %]">click here to login</a>.</p>
>-                        <h4>Local Login</h4>
>+                        <h3>Local Login</h3>
>                     [% END %]
>                 [% END %]
>                 <input type="hidden" name="koha_login_context" value="opac" />
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25155: 105720 | 105722 | 105723 | 105724 | 105755 | 105756 | 105757 | 106618