Attachment 105730 Details for Bug 25236 – Bug 25236: Fix semantic heading for opac-topissues.inc

[patch] Bug 25236: Fix semantic heading for opac-topissues.inc

Bug-25236-Fix-semantic-heading-for-opac-topissuesi.patch (text/plain), 1.66 KB, created by Martin Renvoize (ashimema) on 2020-06-11 11:01:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-06-11 11:01:14 UTC

Size: 1.66 KB

patch

obsolete

>From 6d4cda30478dca57caa4bb673c5d1e83a7620f5d Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 11 Jun 2020 11:44:53 +0100
>Subject: [PATCH] Bug 25236: Fix semantic heading for opac-topissues.inc
>
>Prior to this patch, the opac-topissues side navigation box contained
>semantically incorrect headings.
>
>Test plan
>0/ Enable 'OpacTopIssues'
>1/ Navigate to the top issues page via the 'Most popular' link
>2/ Inspect the 'Refine your search' elements on the left side of the screen.
>   Note that the headings are H1 (Koha page title) > H4 (Refine your search)
>3/ Apply this patch
>4/ Reload the page
>5/ Re-inspect the 'Refine your search' elements and note the heading
>   semantics are now H1 (Title of page) > H2 (Refine your search)
>6/ Note the appearance of the box is still reasonable
>7/ Signoff
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc
>index 6f08f1cd2d..fe07f1e32a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc
>@@ -4,7 +4,7 @@
> 
> <div id="search-facets">
>     <form method="get" action="/cgi-bin/koha/opac-topissues.pl">
>-    <h4><a href="#" class="menu-collapse-toggle">Refine your search</a></h4>
>+    <h2><a href="#" class="menu-collapse-toggle">Refine your search</a></h2>
>             <ul class="menu-collapse">
>                 <li><label for="limit">Show the top </label>
>                             <select name="limit" id="limit">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25236: 105726 | 105727 | 105728 | 105729 | 105730 | 105731 | 105760 | 105761 | 105762 | 106119 | 106120 | 106121