Attachment 105742 Details for Bug 25238 – Bug 25238: Fix semantic heading for opac-details

[patch] Bug 25238: Fix semantic heading for opac-details

Bug-25238-Fix-semantic-heading-for-opac-details.patch (text/plain), 5.18 KB, created by Owen Leonard on 2020-06-11 12:12:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-06-11 12:12:15 UTC

Size: 5.18 KB

patch

obsolete

>From 94e3a3699d4a43f0ccf3b97d34349eb8a64ee5a7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 11 Jun 2020 12:15:21 +0100
>Subject: [PATCH] Bug 25238: Fix semantic heading for opac-details
>
>Prior to this patch the opac-details view contained multiple h1 level
>headings.
>
>Test plan
>1/ Perform a search in the OPAC that will yield results
>2/ Navigate to any results detailed view
>3/ Inspect the page and note that two H1 level headings are present
>(Page title + Item title)
>4/ Apply the patch
>5/ Reload the page
>6/ Inspect the page and ntoe that the 'Item title' is now a level 2
>heading
>7/ Note the page still appears nicely
>8/ Signoff
>
>Bonus points: Check with XSLT views enabled and disabled, MARC21,
>UNIMARC and NORMARC variations.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt          | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl  | 8 ++++----
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 ++--
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index b6c926dbf1..b6fb76f4dc 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -130,7 +130,7 @@
>                     [% IF ( OPACXSLTDetailsDisplay ) %]
>                         [% XSLTBloc | $raw %]
>                     [% ELSE %]
>-                        <h1 class="title">[% INCLUDE 'biblio-title.inc' %]</h1>
>+                        <h2 class="title">[% INCLUDE 'biblio-title.inc' %]</h2>
>                         [% IF ( author ) %]<h5 class="author">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></h5>[% END %]
> 
>                         <span class="results_summary">[% UNLESS ( item_level_itypes ) %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 656c56bc30..afaa37bcd5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -119,17 +119,17 @@
>         
>         
>         <xsl:if test="$display880">
>-            <h1 class="title" property="alternateName">
>+            <h2 class="title" property="alternateName">
>                 <xsl:call-template name="m880Select">
>                     <xsl:with-param name="basetags">245</xsl:with-param>
>                     <xsl:with-param name="codes">abhfgknps</xsl:with-param>
>                 </xsl:call-template>
>-            </h1>
>+            </h2>
>         </xsl:if>
> 
>             
>             <xsl:if test="marc:datafield[@tag=245]">
>-                <h1 class="title" property="name">
>+                <h2 class="title" property="name">
>                     <xsl:for-each select="marc:datafield[@tag=245]">
>                         <xsl:call-template name="subfieldSelect">
>                             <xsl:with-param name="codes">a</xsl:with-param>
>@@ -154,7 +154,7 @@
>                             </xsl:choose>
>                         </xsl:for-each>
>                     </xsl:for-each>
>-                </h1>
>+                </h2>
>             </xsl:if>
> 
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl
>index 28c770204d..3fa217f51d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl
>@@ -67,7 +67,7 @@
> 
>         
>         <xsl:if test="marc:datafield[@tag=245]">
>-        <h1 class="title">
>+        <h2 class="title">
>             <xsl:for-each select="marc:datafield[@tag=245]">
>                     <xsl:call-template name="subfieldSelect">
>                         <xsl:with-param name="codes">a</xsl:with-param>
>@@ -89,7 +89,7 @@
>                         <xsl:with-param name="codes">np</xsl:with-param>
>                     </xsl:call-template>
>             </xsl:for-each>
>-        </h1>
>+        </h2>
>         </xsl:if>
> 
>         
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl
>index e5afad7c67..5186823762 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl
>@@ -25,7 +25,7 @@
> 
>   <xsl:if test="marc:datafield[@tag=200]">
>     <xsl:for-each select="marc:datafield[@tag=200]">
>-      <h1 class="title">
>+      <h2 class="title">
>         <xsl:call-template name="addClassRtl" />
>         <xsl:for-each select="marc:subfield">
>           <xsl:choose>
>@@ -62,7 +62,7 @@
>             </xsl:otherwise>
>           </xsl:choose>
>         </xsl:for-each>
>-      </h1>
>+      </h2>
>     </xsl:for-each>
>   </xsl:if>
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25238: 105733 | 105742 | 106117