Attachment 105760 Details for Bug 25236 – Bug 25236: Fix semantic heading for opac-facets.inc

[patch] Bug 25236: Fix semantic heading for opac-facets.inc

Bug-25236-Fix-semantic-heading-for-opac-facetsinc.patch (text/plain), 5.63 KB, created by PTFS Europe Sandboxes on 2020-06-11 14:39:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: PTFS Europe Sandboxes

Created: 2020-06-11 14:39:25 UTC

Size: 5.63 KB

patch

obsolete

>From d71384a726bda53f64ec5beb847c60a75390d8cb Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 11 Jun 2020 11:37:26 +0100
>Subject: [PATCH] Bug 25236: Fix semantic heading for opac-facets.inc
>
>Prior to this patch, the opac-facets side navigation box contained
>semantically incorrect headings.
>
>Test plan
>1/ Perform a search which yields some results in the OPAC
>2/ Inspect the 'Refine your search' elements on the left side of the
>screen. Note that the headings are H1 (Koha page title) > H4 (Refine
>your search) > H5 (Headings within 'Refine your search' box)
>3/ Apply this patch and follow
>https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
>4/ Reload the page (Flushing the cache to ensure the CSS change load)
>5/ Re-inspect the 'Refine your search' elements and note the heading
>semantics are now H1 (Title of page) > H2 (Refine your search) > H3
>(Headings within 'Refine your search')
>6/ Note the appearance of the box is still reasonable
>7/ Signoff
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |  6 ++++-
> .../bootstrap/en/includes/opac-facets.inc          | 26 +++++++++++-----------
> 2 files changed, 18 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index 8babc17b63..4a18597c5e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -2061,7 +2061,7 @@ input {
>         margin: 0;
>     }
> 
>-    h4 {
>+    h2 {
>         font-size: 90%;
>         margin: 0 0 .6em 0;
>         text-align: center;
>@@ -2076,6 +2076,10 @@ input {
>         }
>     }
> 
>+    h3 {
>+        font-size: 80%;
>+    }
>+
>     li {
>         font-size: 90%;
>         font-weight: bold;
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>index da5e98134e..ddcc3a4b69 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>@@ -3,9 +3,9 @@
> [% USE Languages %]
> [% IF ( opacfacets && facets_loop && total ) %]
>     <div id="search-facets">
>-        <h4><a href="#" class="menu-collapse-toggle">Refine your search</a></h4>
>+        <h2><a href="#" class="menu-collapse-toggle">Refine your search</a></h2>
>         <ul class="menu-collapse">
>-            <li id="availability_facet"><h5 id="facet-availability">Availability</h5>
>+            <li id="availability_facet"><h3 id="facet-availability">Availability</h3>
>                 <ul>
>                     <li>
>                         [% IF ( available ) %]
>@@ -21,19 +21,19 @@
>             [% FOREACH facets_loo IN facets_loop %]
>                 [% IF facets_loo.facets.size > 0 %]
>                     <li id="[% facets_loo.type_id | html %]">
>-                        [% IF facets_loo.type_label_Authors %]<h5 id="facet-authors">Authors</h5>[% END %]
>-                        [% IF facets_loo.type_label_Titles %]<h5 id="facet-titles">Titles</h5>[% END %]
>-                        [% IF facets_loo.type_label_Topics %]<h5 id="facet-topics">Topics</h5>[% END %]
>-                        [% IF facets_loo.type_label_Places %]<h5 id="facet-places">Places</h5>[% END %]
>-                        [% IF facets_loo.type_label_Series %]<h5 id="facet-series">Series</h5>[% END %]
>-                        [% IF facets_loo.type_label_ItemTypes %]<h5 id="facet-itemtypes">Item types</h5>[% END %]
>-                        [% IF facets_loo.type_label_CollectionCodes %]<h5 id="facet-collections">Collections</h5>[% END %]
>-                        [% IF facets_loo.type_label_Language %]<h5 id="facet-languages">Languages</h5>[% END %]
>+                        [% IF facets_loo.type_label_Authors %]<h3 id="facet-authors">Authors</h3>[% END %]
>+                        [% IF facets_loo.type_label_Titles %]<h3 id="facet-titles">Titles</h3>[% END %]
>+                        [% IF facets_loo.type_label_Topics %]<h3 id="facet-topics">Topics</h3>[% END %]
>+                        [% IF facets_loo.type_label_Places %]<h3 id="facet-places">Places</h3>[% END %]
>+                        [% IF facets_loo.type_label_Series %]<h3 id="facet-series">Series</h3>[% END %]
>+                        [% IF facets_loo.type_label_ItemTypes %]<h3 id="facet-itemtypes">Item types</h3>[% END %]
>+                        [% IF facets_loo.type_label_CollectionCodes %]<h3 id="facet-collections">Collections</h3>[% END %]
>+                        [% IF facets_loo.type_label_Language %]<h3 id="facet-languages">Languages</h3>[% END %]
>                         [% UNLESS singleBranchMode %]
>-                            [% IF ( facets_loo.type_label_HomeLibrary ) %]<h5 id="facet-home-libraries">Home libraries</h5>[% END %]
>-                            [% IF ( facets_loo.type_label_HoldingLibrary ) %]<h5 id="facet-holding-libraries">Holding libraries</h5>[% END %]
>+                            [% IF ( facets_loo.type_label_HomeLibrary ) %]<h3 id="facet-home-libraries">Home libraries</h3>[% END %]
>+                            [% IF ( facets_loo.type_label_HoldingLibrary ) %]<h3 id="facet-holding-libraries">Holding libraries</h3>[% END %]
>                         [% END %]
>-                        [% IF facets_loo.type_label_Location %]<h5 id="facet-locations">Locations</h5>[% END %]
>+                        [% IF facets_loo.type_label_Location %]<h3 id="facet-locations">Locations</h3>[% END %]
>                         <ul>
>                             [% SET url = "/cgi-bin/koha/opac-search.pl?" _ query_cgi _ limit_cgi %]
>                             [% IF ( sort_by ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25236: 105726 | 105727 | 105728 | 105729 | 105730 | 105731 | 105760 | 105761 | 105762 | 106119 | 106120 | 106121