Attachment 105767 Details for Bug 25716 – Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder

[patch] Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder

Bug-25716-Add-ability-to-specify-additional-option.patch (text/plain), 2.33 KB, created by Kyle M Hall (khall) on 2020-06-11 15:23:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-06-11 15:23:17 UTC

Size: 2.33 KB

patch

obsolete

>From 6d201f44af816e847f0a56ed7c546a788a7f4479 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 11 Jun 2020 11:17:23 -0400
>Subject: [PATCH] Bug 25716: Add ability to specify additional options in
> koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
>
>The z39.50 responder has a number of command line options that are not
>accessible if using the debian scripts to control it. We should be able
>to set those options in the koha conf file to be passed to the script
>itself.
>
>Test Plan:
>1) Apply this patch
>2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary
>3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>" inside your <config> block in your koha-conf.xml file
>4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k!
>---
> debian/scripts/koha-z3950-responder | 4 +++-
> etc/koha-conf.xml                   | 5 +++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/debian/scripts/koha-z3950-responder b/debian/scripts/koha-z3950-responder
>index 7f34bb4736..a3422d55d4 100755
>--- a/debian/scripts/koha-z3950-responder
>+++ b/debian/scripts/koha-z3950-responder
>@@ -110,13 +110,15 @@ start_z3950()
>     if ! is_z3950_running ${instancename}; then
>         export KOHA_CONF="/etc/koha/sites/${instancename}/koha-conf.xml"
> 
>+        Z3950_ADDITIONAL_OPTS="$( xmlstarlet sel -t -v 'yazgfs/config/z3950_responder_options' $KOHA_CONF )"
>+
>         log_daemon_msg "Starting Z39.50/SRU daemon for ${instancename}"
> 
>         # Change to the instance's user dir
>         current_dir=$(pwd)
>         eval cd ~$instance_user
> 
>-        if ${Z3950RESPONDER} ${Z3950OPTS}; then
>+        if ${Z3950RESPONDER} ${Z3950_ADDITIONAL_OPTS} ${Z3950OPTS}; then
>             log_end_msg 0
>         else
>             log_end_msg 1
>diff --git a/etc/koha-conf.xml b/etc/koha-conf.xml
>index 9e6cb59047..b7c54cb406 100644
>--- a/etc/koha-conf.xml
>+++ b/etc/koha-conf.xml
>@@ -261,5 +261,10 @@ __PAZPAR2_TOGGLE_XML_POST__
>  -->
>  </koha_xslt_security>
> 
>+ 
>+ 
>+
> </config>
> </yazgfs>
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 25716: 105767 | 114166 | 120178 | 125095 | 125096 | 125481 | 125482 | 142520 | 142521 | 142522 | 142577