Bugzilla – Attachment 10577 Details for
Bug 8175
items.materials check logs error or displays incorrectly in details.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8175 - Missing defined check in catalogue/details.pl Actually, just dropping the "ne ''" was better. In some cases $item->{'materials'} isn't defined. Any value is true, so no need for comparison.
Bug-8175---Missing-defined-check-in-cataloguedetai.patch (text/plain), 908 bytes, created by
Chris Cormack
on 2012-07-01 00:56:53 UTC
(
hide
)
Description:
Bug 8175 - Missing defined check in catalogue/details.pl Actually, just dropping the "ne ''" was better. In some cases $item->{'materials'} isn't defined. Any value is true, so no need for comparison.
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2012-07-01 00:56:53 UTC
Size:
908 bytes
patch
obsolete
>From ce69b1529d4bfb9fd05649e380de91986d54c4c3 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 29 Jun 2012 23:13:57 +0800 >Subject: [PATCH] Bug 8175 - Missing defined check in catalogue/details.pl > Actually, just dropping the "ne ''" was better. In some > cases $item->{'materials'} isn't defined. Any value is > true, so no need for comparison. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > catalogue/detail.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index d110740..97ed167 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -261,7 +261,7 @@ foreach my $item (@items) { > $analytics_flag=1; > $item->{countanalytics} = $countanalytics; > } >- if ($item->{'materials'} ne ''){ >+ if ($item->{'materials'}){ > $materials_flag = 1; > } > push @itemloop, $item; >-- >1.7.10
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8175
:
10566
|
10577
|
10620
|
11496
|
11937
|
11956