Attachment 105797 Details for Bug 19185 – Bug 19185: Use submit button if only one exists on the page

[patch] Bug 19185: Use submit button if only one exists on the page

Bug-19185-Use-submit-button-if-only-one-exists-on-.patch (text/plain), 1.30 KB, created by Kyle M Hall (khall) on 2020-06-12 13:35:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-06-12 13:35:26 UTC

Size: 1.30 KB

patch

obsolete

>From bba5690c86f17e603209b1249337bf5a80e0d11f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 4 May 2018 14:44:44 -0300
>Subject: [PATCH] Bug 19185: Use submit button if only one exists on the page
>
>During the installation process we do not have fieldset.action, in order
>to not complicate changes we are just going to use the submit button if
>only one exists.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/lib/Selenium.pm | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm
>index 29f7ef4700..3e8586167b 100644
>--- a/t/lib/Selenium.pm
>+++ b/t/lib/Selenium.pm
>@@ -130,6 +130,13 @@ sub fill_form {
> sub submit_form {
>     my ( $self ) = @_;
> 
>+    # If there is only one submit element on the page we use it
>+    my @submit_elements = $self->driver->find_elements('//input[@type="submit"]');
>+    if ( @submit_elements == 1 ) {
>+        $self->click_when_visible('//input[@type="submit"]');
>+        return;
>+    }
>+
>     my $default_submit_selector = '//fieldset[@class="action"]/input[@type="submit"]';
>     $self->click_when_visible( $default_submit_selector );
> }
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 19185: 66508 | 68830 | 75088 | 75089 | 75090 | 81913 | 81914 | 81915 | 103406 | 103407 | 103408 | 103416 | 105796 | 105797 | 105798 | 105799 | 120273 | 126646 | 126647 | 126648 | 126649 | 126650 | 126651 | 126652 | 126819 | 126901 | 126918 | 126984