Attachment 105829 Details for Bug 24156 – Bug 24156: Fix set sort order to the first column

[patch] Bug 24156: Fix set sort order to the first column

Bug-24156-Fix-set-sort-order-to-the-first-column.patch (text/plain), 1.30 KB, created by Jonathan Druart on 2020-06-12 14:53:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-06-12 14:53:23 UTC

Size: 1.30 KB

patch

obsolete

>From 0e940be7d3be8a8d3494ed274d2fdb6bd110d5e4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 5 Feb 2020 13:00:38 +0100
>Subject: [PATCH] Bug 24156: Fix set sort order to the first column
>
>In that case it's equal to 0 and we need to adjust the test condition.
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>---
> admin/columns_settings.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/admin/columns_settings.pl b/admin/columns_settings.pl
>index afa33c7dbd..51d1d56d75 100755
>--- a/admin/columns_settings.pl
>+++ b/admin/columns_settings.pl
>@@ -53,7 +53,8 @@ if ( $action eq 'save' ) {
>         next unless $table_id =~ m|^([^#]*)#(.*)$|;
>         my $default_display_length = $input->param( $table_id . '_default_display_length' );
>         my $default_sort_order     = $input->param( $table_id . '_default_sort_order' );
>-        if ( $default_display_length && $default_sort_order ) {
>+        if (   defined $default_display_length && $default_display_length ne ""
>+            && defined $default_sort_order     && $default_sort_order     ne "" ) {
>             C4::Utils::DataTables::TablesSettings::update_table_settings(
>                 {
>                     module                 => $module,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24156: 96223 | 96224 | 96225 | 96226 | 96227 | 96228 | 96229 | 96230 | 98449 | 98450 | 98451 | 98452 | 98453 | 98454 | 98455 | 98456 | 98843 | 98844 | 98845 | 98846 | 98847 | 98848 | 99007 | 99008 | 99009 | 99010 | 99011 | 99012 | 99013 | 99014 | 105823 | 105824 | 105825 | 105826 | 105827 | 105828 | 105829 | 106183 | 106184 | 106185 | 106186 | 106187 | 106188 | 106189 | 106190 | 106191 | 106219 | 106220 | 106221 | 106222 | 106223 | 106224 | 106225 | 106226 | 106227 | 106228 | 106245