Bugzilla – Attachment 105856 Details for
Bug 25526
Using Write Off Selected will not allow for a different amount to be written off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25526: Equality matching is case sensative
Bug-25526-Equality-matching-is-case-sensative.patch (text/plain), 2.45 KB, created by
Katrin Fischer
on 2020-06-14 11:38:57 UTC
(
hide
)
Description:
Bug 25526: Equality matching is case sensative
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-06-14 11:38:57 UTC
Size:
2.45 KB
patch
obsolete
>From 77d8d3cf781d1f07b1e8dc0f8fe525a606e74b50 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 8 Jun 2020 10:23:53 +0100 >Subject: [PATCH] Bug 25526: Equality matching is case sensative > >TEST PLAN: >1. Have a fine on a Patron's account. >2. Choose the "Write off Selected" button >3. Enter an amount less than the amount owed by the patron. >4. Koha will give a yellow box with a note "You must collect a value > greater than or equal to 2.00." The $2.00 is the amount that is > attempted to write off (the amount less than the amount owed). >5. Apply patch >6. Again try to writeoff an amount less than the amount owed. >7. You should be able to write it off. >8. Try paying an amount more than owed, you should still get an > error. You shouldn't be able to write off more than the amount. >9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff > selected'. >10. You should not be able to 'Tender' less than the amount you have > 'Paid'. >11. Disable Javascript and run through all the above steps. You should > still be blocked where relevant. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/paycollect.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 43c52c7c7b..c258560bc9 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -43,7 +43,7 @@ my $writeoff_individual = $input->param('writeoff_individual'); > my $change_given = $input->param('change_given'); > my $type = scalar $input->param('type') || 'PAYMENT'; > >-my $updatecharges_permissions = ($writeoff_individual || $type eq 'writeoff') ? 'writeoff' : 'remaining_permissions'; >+my $updatecharges_permissions = ($writeoff_individual || $type eq 'WRITEOFF') ? 'writeoff' : 'remaining_permissions'; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { template_name => 'members/paycollect.tt', > query => $input, >@@ -166,7 +166,7 @@ if ( $total_paid and $total_paid ne '0.00' ) { > error_over => 1, > total_due => $total_due > ); >- } elsif ( $total_collected < $total_paid && !( $writeoff_individual || $type eq 'writeoff') ) { >+ } elsif ( $total_collected < $total_paid && !( $writeoff_individual || $type eq 'WRITEOFF' ) ) { > $template->param( > error_under => 1, > total_paid => $total_paid >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25526
:
105507
|
105528
|
105625
|
105627
|
105637
| 105856