Attachment 105883 Details for Bug 25747 – Bug 25747: Don't display a comma when patron has no firstname

[patch] Bug 25747: Don't display a comma when patron has no firstname

Bug-25747-Dont-display-a-comma-when-patron-has-no-.patch (text/plain), 1.92 KB, created by PTFS Europe Sandboxes on 2020-06-15 13:44:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: PTFS Europe Sandboxes

Created: 2020-06-15 13:44:55 UTC

Size: 1.92 KB

patch

obsolete

>From def71c108ce1cd9ad04a249f0c8de11facbf4f3d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 15 Jun 2020 11:14:22 +0000
>Subject: [PATCH] Bug 25747: Don't display a comma when patron has no firstname
>
>This patch adds a check for the existence of "firstname" to
>patron-title.inc so that if the patron has no firstname the "invert
>name" setting doesn't cause an unnecessary comma to appear.
>
>To test, apply the patch and locate or create a patron with no first
>name.
>
>- When checking out to the patron, examine the page title. It should say
>  "Checking out to <lastname> (<cardnumber>).
>- When checking out to a patron with first and last name it should show
>  as before, "Checking out to <lastname>, <firstname> (<cardnumber)
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
>index d5dcd7d0f0..71a293588a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
>@@ -60,7 +60,7 @@
>     [%- IF data.category_type == 'I' -%]
>         [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%]
>     [%- ELSIF invert_name -%]
>-        [% data.title | $raw %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%]
>+        [% data.title | $raw %][%- data.surname | html %][% IF ( data.firstname ) %], [% data.firstname | html %][% END %][% IF data.othernames %] ([% data.othernames | html %]) [% END -%]
>     [%- ELSE -%]
>         [% data.title | $raw %][%- data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END %] [% data.surname | html -%]
>     [%- END -%]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25747: 105871 | 105883 | 106115