Attachment 105993 Details for Bug 25783 – Bug 25783: Holds Queue treating item-level holds as bib-level

[patch] Bug 25783: Holds Queue treating item-level holds as bib-level

Bug-25783-Holds-Queue-treating-item-level-holds-as.patch (text/plain), 3.02 KB, created by Andrew Fuerste-Henry on 2020-06-18 01:41:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2020-06-18 01:41:33 UTC

Size: 3.02 KB

patch

obsolete

>From 9a81a9ab4b6aea8b40661a21beedcb769bf3dfd7 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 17 Jun 2020 11:41:21 -0400
>Subject: [PATCH] Bug 25783: Holds Queue treating item-level holds as bib-level
>
>The holds queue builder does not honor
>the new item_level_hold flag. Instead, it only item_level_request if
>in the loop dealing with item level holds. This is incorrect. Item level
>holds may be trapped in the local holds priority loop as well. It's
>trivial to just pass though the correct item/biblio level hold flag.
>
>I do not know how to write a reproducable test plan for these issues.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Kim Peine <kim@williston.lib.vt.us>
>---
> C4/HoldsQueue.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm
>index 5f2c2c556c..18a9063e53 100755
>--- a/C4/HoldsQueue.pm
>+++ b/C4/HoldsQueue.pm
>@@ -277,7 +277,7 @@ sub GetPendingHoldRequestsForBib {
>     my $dbh = C4::Context->dbh;
> 
>     my $request_query = "SELECT biblionumber, borrowernumber, itemnumber, priority, reserves.branchcode,
>-                                reservedate, reservenotes, borrowers.branchcode AS borrowerbranch, itemtype
>+                                reservedate, reservenotes, borrowers.branchcode AS borrowerbranch, itemtype, item_level_hold
>                          FROM reserves
>                          JOIN borrowers USING (borrowernumber)
>                          WHERE biblionumber = ?
>@@ -436,7 +436,7 @@ sub MapItemsToHoldRequests {
>                             holdingbranch  => $item->{holdingbranch},
>                             pickup_branch  => $request->{branchcode}
>                               || $request->{borrowerbranch},
>-                            item_level   => 0,
>+                            item_level   => $request->{item_level_hold},
>                             reservedate  => $request->{reservedate},
>                             reservenotes => $request->{reservenotes},
>                         };
>@@ -475,7 +475,7 @@ sub MapItemsToHoldRequests {
>                     biblionumber   => $request->{biblionumber},
>                     holdingbranch  => $items_by_itemnumber{ $request->{itemnumber} }->{holdingbranch},
>                     pickup_branch  => $request->{branchcode} || $request->{borrowerbranch},
>-                    item_level     => 1,
>+                    item_level     => $request->{item_level_hold},
>                     reservedate    => $request->{reservedate},
>                     reservenotes   => $request->{reservenotes},
>                 };
>@@ -650,7 +650,7 @@ sub MapItemsToHoldRequests {
>                 biblionumber => $request->{biblionumber},
>                 holdingbranch => $holdingbranch,
>                 pickup_branch => $pickup_branch,
>-                item_level => 0,
>+                item_level => $request->{item_level_hold},
>                 reservedate => $request->{reservedate},
>                 reservenotes => $request->{reservenotes},
>             };
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25783: 105973 | 105974 | 105982 | 105983 | 105984 | 105992 | 105993 | 106166