Attachment 106003 Details for Bug 25801 – Bug 25801: Add itemnumber parameter to opac-detail

[patch] Bug 25801: Add itemnumber parameter to opac-detail

Bug-25801-Add-itemnumber-parameter-to-opac-detail.patch (text/plain), 3.11 KB, created by Marcel de Rooy on 2020-06-18 12:08:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-06-18 12:08:19 UTC

Size: 3.11 KB

patch

obsolete

>From b3e3eb5211eb5c8e16559ef8541c0ad6eab05895 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 18 Jun 2020 11:34:27 +0000
>Subject: [PATCH] Bug 25801: Add itemnumber parameter to opac-detail
>Content-Type: text/plain; charset=utf-8
>
>Note: The GetItemsInfo call is now suboptimal. Leaving it as-is
>for now in the hope that item refactoring picks it up ;)
>
>Test plan:
>Test opac-detail via biblionumber (regular use).
>Test opac-detail by passing an itemnumber in the URL.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> opac/opac-detail.pl | 7 +++++++
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index b6c926dbf1..50ad6ce77c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -479,8 +479,8 @@
> [% ELSE %]
> <li id="tab_holdings">
> [% END %]
>- [% BLOCK holding_tab_title %][% IF SeparateHoldings %][% LoginBranchname | html %] holdings[% ELSE %]Holdings[% END %][% END %]
>- <a href="#holdings">[% PROCESS holding_tab_title %] [% UNLESS too_many_items %][% ' ( ' _ (itemloop.size || 0) _ ' )' | html %][% END %]</a>
>+ [% BLOCK holding_tab_title %][% IF SeparateHoldings %][% LoginBranchname | html %] holdings[% ELSE %][% IF specific_item %]Item details[% ELSE %]Holdings[% END %][% END %][% END %]
>+ <a href="#holdings">[% PROCESS holding_tab_title %] [% UNLESS too_many_items OR specific_item %][% ' ( ' _ (itemloop.size || 0) _ ' )' | html %][% END %]</a>
> </li>
> [% IF (SeparateHoldings) %]
> <li><a href="#otherholdings">Other holdings [% ' ( ' _ (otheritemloop.size || 0) _ ' )' | html %]</a></li>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 5c1880fbed..ce091b78fb 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -67,6 +67,9 @@ my $query = CGI->new();
> my $biblionumber = $query->param('biblionumber') || $query->param('bib') || 0;
> $biblionumber = int($biblionumber);
> 
>+my $specific_item = $query->param('itemnumber') ? Koha::Items->find( scalar $query->param('itemnumber') ) : undef;
>+$biblionumber = $specific_item->biblionumber if $specific_item;
>+
> my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
> {
> template_name => "opac-detail.tt",
>@@ -77,6 +80,10 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
> );
> 
> my @all_items = GetItemsInfo($biblionumber);
>+if( $specific_item ) {
>+ @all_items = grep { $_->{itemnumber} == $query->param('itemnumber') } @all_items;
>+ $template->param( specific_item => 1 );
>+}
> my @hiddenitems;
> my $patron = Koha::Patrons->find( $borrowernumber );
> our $borcat= q{};
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25801: 106003 | 106004 | 106321 | 106322 | 106323 | 106366 | 106367 | 106368