Bugzilla – Attachment 106030 Details for
Bug 25805
SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
Bug-25805-SIP-will-show-hold-patron-name-DA-as-som.patch (text/plain), 1.74 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-06-18 19:59:04 UTC
(
hide
)
Description:
Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-06-18 19:59:04 UTC
Size:
1.74 KB
patch
obsolete
>From 01904aec2ddeddb1e52f5c54215e9156e3df6ee6 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 18 Jun 2020 09:01:36 -0400 >Subject: [PATCH] Bug 25805: SIP will show hold patron name (DA) as something > like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron > >This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. >The subroutine hold_patron_bcode should always return an empty string, not undef. > >Test Plan: >1) Using the SIP cli emulator, checkin an item that is not checked out >2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" > The hex number will almost certainly be different from this example >3) Apply this patch >4) Restart the SIP server >5) Run the SIP checkin again >6) Note the DA field is no longer present! > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/SIP/ILS/Item.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index 246acfa7667..705abd70dce 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >@@ -167,7 +167,7 @@ sub hold_patron_id { > } > sub hold_patron_name { > my ( $self, $template ) = @_; >- my $borrowernumber = $self->hold_patron_id() or return; >+ my $borrowernumber = $self->hold_patron_id() or return q{}; > > if ($template) { > my $tt = Template->new(); >@@ -182,7 +182,7 @@ sub hold_patron_name { > my $holder = Koha::Patrons->find( $borrowernumber ); > unless ($holder) { > siplog("LOG_ERR", "While checking hold, failed to retrieve the patron with borrowernumber '$borrowernumber'"); >- return; >+ return q{}; > } > my $email = $holder->email || ''; > my $phone = $holder->phone || ''; >-- >2.27.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25805
:
106009
|
106029
|
106030
|
106078
|
106079
|
106257