Bugzilla – Attachment 106094 Details for
Bug 11994
Fix OpenSearch discovery in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11994: (follow-up) Make things work when LibraryName is empty
Bug-11994-follow-up-Make-things-work-when-LibraryN.patch (text/plain), 2.10 KB, created by
Martin Renvoize (ashimema)
on 2020-06-19 13:26:18 UTC
(
hide
)
Description:
Bug 11994: (follow-up) Make things work when LibraryName is empty
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-06-19 13:26:18 UTC
Size:
2.10 KB
patch
obsolete
>From c23e679813ea2f5fa45318948e46bef4f7d411c9 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 1 May 2020 20:11:29 +0000 >Subject: [PATCH] Bug 11994: (follow-up) Make things work when LibraryName is > empty > >When LibraryName system preference was not set, the installation >of the plugin would fail with: > >Firefox could not download the search plugin from: ... > >Now if the pref is empty, the description 'Library catalog' >will be used instead. > >To test: >- Empty your LibraryName pref >- Verify the search plugin can still be installed > (see first patch for further instructions) > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../bootstrap/en/modules/opac-opensearch.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >index 7b43110ddc..43d205ecbe 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt >@@ -1,12 +1,12 @@ >-<?xml version='1.0' encoding='utf-8' ?> >-[% USE raw %] >-[% USE Koha %] >-[% SET AdlibrisEnabled = Koha.Preference('AdlibrisCoversEnabled') %] >-[% SET AdlibrisURL = Koha.Preference('AdlibrisCoversURL') %] >+<?xml version='1.0' encoding='utf-8' ?> >+[%- USE raw -%] >+[%- USE Koha -%] >+[%- SET AdlibrisEnabled = Koha.Preference('AdlibrisCoversEnabled') -%] >+[%- SET AdlibrisURL = Koha.Preference('AdlibrisCoversURL') -%] > > [% IF ( opensearchdescription ) %] > <OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/"> >- <ShortName>[% LibraryNameTitle | html %]</ShortName> >+ <ShortName>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Library catalog[% END %]</ShortName> > <Description>Search the [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha library[% END %] catalog</Description> > <InputEncoding>UTF-8</InputEncoding> > <Image width="16" height="16" type="image/x-icon"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11994
:
103866
|
103873
|
103874
|
104132
|
104133
|
104134
|
104135
|
104138
|
104139
|
104140
|
106092
|
106093
| 106094