Bugzilla – Attachment 106097 Details for
Bug 24190
Add additional Acquisition logging
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24190: (follow-up) Cancel order del item bug
Bug-24190-follow-up-Cancel-order-del-item-bug.patch (text/plain), 1.54 KB, created by
Martin Renvoize (ashimema)
on 2020-06-19 14:09:13 UTC
(
hide
)
Description:
Bug 24190: (follow-up) Cancel order del item bug
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-06-19 14:09:13 UTC
Size:
1.54 KB
patch
obsolete
>From b8203c46892ddc7bae31d5874d36244542be50a0 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Tue, 19 May 2020 12:06:47 +0100 >Subject: [PATCH] Bug 24190: (follow-up) Cancel order del item bug > >If an order is cancelled but the associated bib / items are unable to be >removed, we go into error handling. We still need to log the >cancellation though. So this fix moves the logging to just after the >cancellation, so it will be logged regardless of the outcome with >associated things. >--- > acqui/cancelorder.pl | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/acqui/cancelorder.pl b/acqui/cancelorder.pl >index 71467a10d1..ab0a838372 100755 >--- a/acqui/cancelorder.pl >+++ b/acqui/cancelorder.pl >@@ -60,15 +60,16 @@ if($action and $action eq "confirmcancel") { > my $reason = $input->param('reason'); > my $error = DelOrder($biblionumber, $ordernumber, $del_biblio, $reason); > >+ # Log the cancellation of the order >+ if (C4::Context->preference("AcqLog")) { >+ logaction('ACQUISITIONS', 'CANCEL_ORDER', $ordernumber); >+ } >+ > if($error) { > $template->param(error_delitem => 1) if $error->{'delitem'}; > $template->param(error_delbiblio => 1) if $error->{'delbiblio'}; > } else { > $template->param(success_cancelorder => 1); >- # Log the cancellation of the order >- if (C4::Context->preference("AcqLog")) { >- logaction('ACQUISITIONS', 'CANCEL_ORDER', $ordernumber); >- } > } > $template->param(confirmcancel => 1); > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24190
:
96364
|
96369
|
100243
|
105082
|
105083
|
106096
|
106097
|
106098
|
106099
|
111080
|
111081
|
111082
|
111083
|
111084
|
112509
|
112510
|
112511
|
112512
|
112513
|
112514
|
116148
|
116149
|
116150
|
116151
|
116152
|
116153
|
122040
|
122041
|
122042
|
122043
|
122044
|
122045
|
123385
|
123386
|
123387
|
123388
|
123389
|
123390
|
123391
|
125119