Attachment 10611 Details for Bug 5725 – BZ5725 follow-up for comment 48

[patch] BZ5725 follow-up for comment 48

BZ5725-follow-up-for-comment-48.patch (text/plain), 2.91 KB, created by Paul Poulain on 2012-07-02 15:42:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2012-07-02 15:42:34 UTC

Size: 2.91 KB

patch

obsolete

>From da507ecba232cfe50e3fdd7d8e5ddef46824310f Mon Sep 17 00:00:00 2001
>From: Paul Poulain <paul.poulain@biblibre.com>
>Date: Mon, 2 Jul 2012 17:41:07 +0200
>Subject: [PATCH] BZ5725 follow-up for comment 48
>
>This small follow up:
>  * removes "whole field" in subfield list except when dealing with a field <010 (that has no subfield)
>  * add a missing string resulting in an "undefined" when user choosed 'Create field and subfield' and hit Add button
>  * synch the description after adding with the description in the list box of the 4 options available
>  * fixes indentation a little
>---
> .../prog/en/modules/tools/batchedit.tt             |   22 ++++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt
>index faed49e..f06cf8d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt
>@@ -10,20 +10,20 @@
> 
>      function fieldChanged(){
>         var field = $('#fieldchoice').val();
>-        $("#loading").html(" <img src=\"/intranet-tmpl/prog/img/loading-small.gif\" alt=\"\" />");
>+        $("#loading").html(" <img src=\"/intranet-tmpl/prog/img/loading.gif\" alt=\"\" />");
>         $.ajax({
>-        url: CGIBIN + 'tools/batchedit.pl?field=' + field,
>-        dataType: 'json',
>+       url: CGIBIN + 'tools/batchedit.pl?field=' + field,
>+       dataType: 'json',
>             success: function(data){
>             $("#loading").html("");
>-        $("#subfieldchoice option").remove();
>+       $("#subfieldchoice option").remove();
> 
>-            var subfield = $('#subfieldchoice');
>-            $("<option>").attr("value", "@")
>+           var subfield = $('#subfieldchoice');
>+           $("<option>").attr("value", "@")
>                                  .text( _('Whole field'))
>                                  .appendTo('#subfieldchoice');
>                 for( var i=0; i < data.length ; i++){
>-            $("<option>").attr("value", data[i].subfield)
>+           $("<option>").attr("value", data[i].subfield)
>                                  .text(data[i].subfield)
>                                  .appendTo('#subfieldchoice');
>                 }
>@@ -31,7 +31,6 @@
>             }
>         });
>      }
>-
>      function subfieldChanged(){
>         var field    = $('#fieldchoice').val();
>         var subfield = $('#subfieldchoice').val();
>@@ -70,9 +69,10 @@
> 
>      function addRule(){
>         var actionlabel = {
>-                mod: _('Modify'),
>-                del: _('Delete'),
>-                add: _('Create')
>+                mod: _('Modify subfield'),
>+                del: _('Delete subfield'),
>+                add: _('Create subfield'),
>+                addfield: _('Create field and subfield')
>                 };
>         var repvallabel  = $('#repvalchoice :selected').text()  || $("#repvalchoice").val();
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 5725: 3105 | 3108 | 3191 | 3193 | 3234 | 3356 | 4734 | 4735 | 4736 | 4863 | 4864 | 4897 | 4898 | 4899 | 5404 | 5405 | 5684 | 5685 | 5697 | 5959 | 5960 | 5980 | 5981 | 5982 | 10610 | 10611 | 10612 | 11731 | 11732 | 11733