Attachment 10616 Details for Bug 5327 – bug 5327: added some tests for C4/Items.pm

[patch] bug 5327: added some tests for C4/Items.pm

bug-5327-added-some-tests-for-C4Itemspm.patch (text/plain), 2.78 KB, created by Jared Camins-Esakov on 2012-07-02 17:30:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2012-07-02 17:30:32 UTC

Size: 2.78 KB

patch

obsolete

>From 47c5483307aa94aa90fcc1ace5d15a82153fc78b Mon Sep 17 00:00:00 2001
>From: Stacey Walker <stacey@catalyst-eu.net>
>Date: Mon, 11 Jun 2012 17:06:00 +0100
>Subject: [PATCH] bug 5327: added some tests for C4/Items.pm
>Content-Type: text/plain; charset="UTF-8"
>
>Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
>---
> t/Items.t              |   14 ------------
> t/db_dependent/Items.t |   54 ++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+), 14 deletions(-)
> delete mode 100755 t/Items.t
> create mode 100755 t/db_dependent/Items.t
>
>diff --git a/t/Items.t b/t/Items.t
>deleted file mode 100755
>index c19cdc7..0000000
>--- a/t/Items.t
>+++ /dev/null
>@@ -1,14 +0,0 @@
>-#!/usr/bin/perl
>-#
>-# This Koha test module is a stub!  
>-# Add more tests here!!!
>-
>-use strict;
>-use warnings;
>-
>-use Test::More tests => 1;
>-
>-BEGIN {
>-        use_ok('C4::Items');
>-}
>-
>diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t
>new file mode 100755
>index 0000000..be209c8
>--- /dev/null
>+++ b/t/db_dependent/Items.t
>@@ -0,0 +1,54 @@
>+#!/usr/bin/perl
>+#
>+# This Koha test module is a stub!
>+# Add more tests here!!!
>+
>+use strict;
>+use warnings;
>+use MARC::Record;
>+use C4::Biblio;
>+
>+use Test::More tests => 7;
>+
>+BEGIN {
>+    use_ok('C4::Items');
>+}
>+
>+# Helper biblio.
>+diag("Creating biblio instance for testing.");
>+my ($bibnum, $bibitemnum) = get_biblio();
>+
>+# Add an item.
>+my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
>+cmp_ok($item_bibnum, '==', $bibnum, "New item is linked to correct biblionumber.");
>+cmp_ok($item_bibitemnum, '==', $bibitemnum, "New item is linked to correct biblioitemnumber.");
>+
>+# Get item.
>+my $getitem = GetItem($itemnumber);
>+cmp_ok($getitem->{'itemnumber'}, '==', $itemnumber, "Retrieved item has correct itemnumber.");
>+cmp_ok($getitem->{'biblioitemnumber'}, '==', $item_bibnum, "Retrieved item has correct biblioitemnumber.");
>+
>+# Modify item; setting barcode.
>+ModItem({ barcode => '987654321' }, $bibnum, $itemnumber);
>+my $moditem = GetItem($itemnumber);
>+cmp_ok($moditem->{'barcode'}, '==', '987654321', 'Modified item barcode successfully to: '.$moditem->{'barcode'} . '.');
>+
>+# Delete item.
>+my $dbh = C4::Context->dbh;
>+DelItem($dbh, $bibnum, $itemnumber);
>+my $getdeleted = GetItem($itemnumber);
>+is($getdeleted->{'itemnumber'}, undef, "Item deleted as expected.");
>+
>+# Delete helper Biblio.
>+diag("Deleting biblio testing instance.");
>+DelBiblio($bibnum);
>+
>+# Helper method to set up a Biblio.
>+sub get_biblio {
>+    my $bib = MARC::Record->new();
>+    $bib->append_fields(
>+        MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
>+        MARC::Field->new('245', ' ', ' ', a => 'Silence in the library'),
>+    );
>+    return ($bibnum, $bibitemnum) = AddBiblio($bib, '');
>+}
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 5327: 2716 | 2726 | 5485 | 6236 | 6237 | 6373 | 6560 | 6561 | 6562 | 6563 | 6613 | 6614 | 6616 | 6620 | 6621 | 6622 | 6643 | 6650 | 6655 | 6679 | 6681 | 6682 | 6683 | 6726 | 6727 | 6728 | 6729 | 6730 | 6731 | 6732 | 6795 | 6799 | 6805 | 6819 | 6826 | 6827 | 6828 | 6834 | 7179 | 7180 | 7181 | 7182 | 7183 | 7184 | 7185 | 7186 | 7187 | 7188 | 7189 | 7190 | 7191 | 7192 | 7194 | 7195 | 7203 | 7206 | 7208 | 7209 | 7220 | 7221 | 7222 | 7223 | 7224 | 7225 | 7226 | 7227 | 7228 | 7229 | 7230 | 7231 | 7232 | 7233 | 7234 | 7235 | 7236 | 7237 | 7238 | 7239 | 7240 | 7241 | 7242 | 7400 | 7402 | 7403 | 7405 | 7573 | 7592 | 7593 | 7594 | 9897 | 10234 | 10616 | 10656 | 10659 | 10660 | 10661 | 10680 | 11141 | 11186 | 11212 | 11213 | 11278 | 11279 | 11280 | 11281 | 11339 | 11340 | 11341 | 11440 | 11467 | 11469 | 11470 | 11471 | 11472 | 11473 | 11500 | 11503 | 11505 | 11506 | 11633 | 11762 | 11763 | 11764 | 11765 | 11846 | 11985 | 11993 | 12002 | 12003