Bugzilla – Attachment 106179 Details for
Bug 25842
Typo "streetype" in member-main-address-style.inc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25842: Fix typo streetype in member-main-address-style.inc
Bug-25842-Fix-typo-streetype-in-member-main-addres.patch (text/plain), 2.41 KB, created by
Fridolin Somers
on 2020-06-23 07:33:43 UTC
(
hide
)
Description:
Bug 25842: Fix typo streetype in member-main-address-style.inc
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2020-06-23 07:33:43 UTC
Size:
2.41 KB
patch
obsolete
>From 336efd8ba889d493775560f77514eff980ab5ade Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 23 Jun 2020 09:25:33 +0200 >Subject: [PATCH] Bug 25842: Fix typo streetype in > member-main-address-style.inc > >There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory. > >See also : >Bug 25839 - Typo patron.streetype in member-main-address-style.inc > >Test plan : >1) Add "streettype" in system preference "BorrowerMandatoryField" >2) Create a new patron >3) Without patch "Street type" field is not mandatory/required, with > patch it is >4) Remove "streettype" from system preference "BorrowerMandatoryField" >5) Create a new patron >6) Check "Street type" field is not mandatory/required >7) Select a value and save >8) Edit again patron >9) Check value is selected >--- > .../prog/en/includes/member-main-address-style.inc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc >index edee601741..bd384ed1b5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc >@@ -48,13 +48,13 @@ > [% BLOCK 'address-style_roadtypes' %] > [% IF roadtypes %] > <li> >- [% IF ( mandatorystreetype ) %] >- <label for="streetype" class="required"> >+ [% IF ( mandatorystreettype ) %] >+ <label for="streettype" class="required"> > [% ELSE %] >- <label for="streetype"> >+ <label for="streettype"> > [% END %] > Street type: </label> >- <select name="streetype"> >+ <select name="streettype"> > <option value=""></option> > [% FOR roadtype IN roadtypes %] > [% IF roadtype.authorised_value == patron.streettype %] >@@ -64,7 +64,7 @@ > [% END %] > [% END %] > </select> >- [% IF ( mandatorystreetype ) %]<span class="required">Required</span>[% END %] >+ [% IF ( mandatorystreettype ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > [% END %] >-- >2.27.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25842
:
106179
|
106181