Attachment 106182 Details for Bug 25237 – Bug 25237: Fix semantic heading for opac-details

[patch] Bug 25237: Fix semantic heading for opac-details

Bug-25237-Fix-semantic-heading-for-opac-details.patch (text/plain), 3.89 KB, created by ByWater Sandboxes on 2020-06-23 08:47:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2020-06-23 08:47:32 UTC

Size: 3.89 KB

patch

obsolete

>From 39f051ae2f77070b53085dc5a164a7cf9df4139a Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 11 Jun 2020 12:45:57 +0100
>Subject: [PATCH] Bug 25237: Fix semantic heading for opac-details
>
>Prior to this patch the opac-details view contained semantically incorrect h3
>headings for the author information.
>
>Test plan
>1/ Perform a search in the OPAC that will yield results
>2/ Navigate to any results detailed view
>3/ Inspect the page and note that there are semantically incorrect headings
>   H1 (Page title) > H2 (Item title) > H5 (Author)
>4/ Apply the patch
>5/ Reload the page
>6/ Inspect the page and note that the semantically incorrect author block has
>   been converted to a span with an 'h3' class for styling
>7/ Note the page still appears nicely
>8/ Signoff
>
>Bonus points: Check with XSLT views enabled and disabled.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt         | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 4ffcb4e8f9..b00488afed 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -131,7 +131,7 @@
>                         [% XSLTBloc | $raw %]
>                     [% ELSE %]
>                         <h2 class="title">[% INCLUDE 'biblio-title.inc' %]</h2>
>-                        [% IF ( author ) %]<h5 class="author">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></h5>[% END %]
>+                        [% IF ( author ) %]<span class="results_summary author h3">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></span>[% END %]
> 
>                         <span class="results_summary">[% UNLESS ( item_level_itypes ) %]
>                             [
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index afaa37bcd5..8286a94fc4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -160,14 +160,14 @@
> 
>         
>         <xsl:if test="$display880">
>-            <h5 class="author">
>+            <span class="results_summary author h3">
>                 <xsl:call-template name="m880Select">
>                     <xsl:with-param name="basetags">100,110,111,700,710,711</xsl:with-param>
>                     <xsl:with-param name="codes">abc</xsl:with-param>
>                     <xsl:with-param name="index">au</xsl:with-param>
>                     
>                 </xsl:call-template>
>-            </h5>
>+            </span>
>         </xsl:if>
> 
>         
>@@ -1566,7 +1566,7 @@
>         <xsl:param name="materialTypeLabel" />
>         <xsl:param name="theme" />
>         <xsl:if test="count($authorfield)&gt;0">
>-        <h5 class="author">
>+        <span class="results_summary author h3">
>             <xsl:for-each select="$authorfield">
>                 <xsl:choose>
>                     <xsl:when test="position()&gt;1"/>
>@@ -1832,7 +1832,7 @@
>                     <xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><span class="separator"><xsl:text> | </xsl:text></span></xsl:otherwise>
>                 </xsl:choose>
>             </xsl:for-each>
>-        </h5>
>+        </span>
>         </xsl:if>
>     </xsl:template>
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25237: 105737 | 106182 | 106619