Attachment 106232 Details for Bug 25630 – Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences

[patch] Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences

Bug-25630-Fix-capitalization-and-terminology-for-A.patch (text/plain), 4.22 KB, created by David Nind on 2020-06-24 09:27:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-06-24 09:27:26 UTC

Size: 4.22 KB

patch

obsolete

>From 37ee22c1f188cd9b94ff8437c50db84a10ad8242 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 31 May 2020 16:10:23 +0200
>Subject: [PATCH] Bug 25630: Fix capitalization and terminology for
> Acquisitions and Tools system preferences
>
>- Adds some ending punctuation
>- Fixes capitalization
>- Consistent use of "staff interface"
>
>To test:
>- Verify:
>  - NewsAuthorDisplay
>  - EmailPurchaseSuggestions
>  - UseACQFrameworkForBiblioRecords
>  - AcqItemSetSubfieldsWhenReceived
>  - AcqItemSetSubfieldsWhenReceiptIsCancelled
>  - OrderPriceRounding
>- read correctly.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/admin/preferences/acquisitions.pref        | 10 +++++-----
> .../intranet-tmpl/prog/en/modules/admin/preferences/tools.pref |  9 +++++----
> 2 files changed, 10 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>index c6d8d8d55c..16e27be077 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>@@ -45,10 +45,10 @@ Acquisitions:
>                   no: "Do not warn"
>             - when the librarian tries to create an invoice with a duplicate number.
>         -
>-            - Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar").
>+            - "Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a=\"foo bar\"):"
>             - pref: AcqItemSetSubfieldsWhenReceived
>         -
>-            - Upon cancelling a receipt, update the item's subfields if they were created when placing an order (e.g. o=5|a="bar foo").
>+            - "Upon cancelling a receipt, update the item's subfields if they were created when placing an order (e.g. o=5|a=\"bar foo\"):"
>             - pref: AcqItemSetSubfieldsWhenReceiptIsCancelled
>         -
>             - pref: AcqEnableFiles
>@@ -91,20 +91,20 @@ Acquisitions:
>                 '': Don't round
>                 nearest_cent: Round
>             - to nearest cent.<br>
>-            - Determines whether full precision values or rounded values should be used in price calculations
>+            - Determines whether full precision values or rounded values should be used in price calculations.
>         -
>             - pref: UseACQFrameworkForBiblioRecords
>               default: no
>               choices:
>                 yes: "Use"
>                 no: "Don't use"
>-            - " the framework 'ACQ' for bibliographic records fields"
>+            - " the framework 'ACQ' for bibliographic records fields."
>         -
>             - "Choose email address that new purchase suggestions will be sent to: "
>             - pref: EmailPurchaseSuggestions
>               default: 0
>               choices:
>-                  0: None
>+                  0: none
>                   EmailAddressForSuggestions: EmailAddressForSuggestions
>                   BranchEmailAddress: email address of branch
>                   KohaAdminEmailAddress: KohaAdminEmailAddress
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>index 1d4f2965ef..f8b657e691 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>@@ -32,10 +32,11 @@ Tools:
>             - "Show the author for news items:"
>             - pref: NewsAuthorDisplay
>               choices:
>-                  none: "Not at all"
>+                  none: "not at all"
>                   opac: "OPAC only"
>-                  staff: "Staff client only"
>-                  both: "Both OPAC and staff client"
>+                  staff: "staff interface only"
>+                  both: "both OPAC and staff interface"
>+            - "."
>             -
>     Upload:
>         -
>@@ -48,4 +49,4 @@ Tools:
>             - By default, show
>             - pref: NumSavedReports
>               class: integer
>-            - reports on the Saved Reports page.
>+            - reports on the Saved reports page.
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25630: 105459 | 105460 | 105461 | 105462 | 105463 | 105464 | 105465 | 105466 | 105467 | 105468 | 106230 | 106231 | 106232 | 106233 | 106234 | 106235 | 106236 | 106237 | 106238 | 106239 | 106266 | 107058 | 107059 | 107060 | 107061 | 107062 | 107063 | 107064 | 107065 | 107066 | 107067 | 107068 | 108260 | 108261 | 108262 | 108263 | 108264 | 108265 | 108266 | 108267 | 108268 | 108269 | 108270 | 108910 | 108911 | 108912 | 108913 | 108914 | 108915 | 108916 | 108917 | 108918 | 108919 | 108920 | 109446 | 109447 | 109448 | 109449 | 109450 | 109451 | 109452 | 109453 | 109454 | 109455 | 109456