Attachment 106257 Details for Bug 25805 – Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name

[patch] Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name

Bug-25805-Return-empty-strings-instead-of-undef-in.patch (text/plain), 1.78 KB, created by Kyle M Hall (khall) on 2020-06-24 15:46:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-06-24 15:46:12 UTC

Size: 1.78 KB

patch

obsolete

>From ff15a6c6809cedfedfdda5f55f009c961a69b8b3 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 18 Jun 2020 09:01:36 -0400
>Subject: [PATCH] Bug 25805: Return empty strings instead of undef in
> C4::SIP::ILS::Item::hold_patron_name
>
>This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode.
>The subroutine hold_patron_bcode should always return an empty string, not undef.
>
>Test Plan:
>1) Using the SIP cli emulator, checkin an item that is not checked out
>2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)"
>   The hex number will almost certainly be different from this example
>3) Apply this patch
>4) Restart the SIP server
>5) Run the SIP checkin again
>6) Note the DA field is no longer present!
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/SIP/ILS/Item.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
>index 246acfa766..705abd70dc 100644
>--- a/C4/SIP/ILS/Item.pm
>+++ b/C4/SIP/ILS/Item.pm
>@@ -167,7 +167,7 @@ sub hold_patron_id {
> }
> sub hold_patron_name {
>     my ( $self, $template ) = @_;
>-    my $borrowernumber = $self->hold_patron_id() or return;
>+    my $borrowernumber = $self->hold_patron_id() or return q{};
> 
>     if ($template) {
>         my $tt = Template->new();
>@@ -182,7 +182,7 @@ sub hold_patron_name {
>     my $holder = Koha::Patrons->find( $borrowernumber );
>     unless ($holder) {
>         siplog("LOG_ERR", "While checking hold, failed to retrieve the patron with borrowernumber '$borrowernumber'");
>-        return;
>+        return q{};
>     }
>     my $email = $holder->email || '';
>     my $phone = $holder->phone || '';
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 25805: 106009 | 106029 | 106030 | 106078 | 106079 | 106257