Attachment 106300 Details for Bug 25440 – Bug 25440: Extra duplicated call to CGI->param method removed

[patch] Bug 25440: Extra duplicated call to CGI->param method removed

Bug-25440-Extra-duplicated-call-to-CGI-param-metho.patch (text/plain), 1.74 KB, created by Martin Renvoize (ashimema) on 2020-06-25 14:41:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-06-25 14:41:24 UTC

Size: 1.74 KB

patch

obsolete

>From c6df46003f2d8e99ae892afc5fd1f1ae2a7f4d5f Mon Sep 17 00:00:00 2001
>From: Andrew Nugged <nugged@gmail.com>
>Date: Sun, 10 May 2020 13:54:29 +0300
>Subject: [PATCH] Bug 25440: Extra duplicated call to CGI->param method removed
>
>In code CGI param 'no_auto_renewal_after_hard_limit' assigned to
>"$no_auto_renewal_after_hard_limit" var, and then just in the next line
>again variable "$no_auto_renewal_after_hard_limit" reassigned with
>call to same "$input->param('no_auto_renewal_after_hard_limit')".
>
>Fixed. No logic or results should be changed.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> admin/smart-rules.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 20da1b1d6d..874efb0e5c 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -271,7 +271,7 @@ elsif ($op eq 'add') {
>     my $no_auto_renewal_after = $input->param('no_auto_renewal_after');
>     $no_auto_renewal_after = '' if $no_auto_renewal_after =~ /^\s*$/;
>     my $no_auto_renewal_after_hard_limit = $input->param('no_auto_renewal_after_hard_limit') || '';
>-    $no_auto_renewal_after_hard_limit = eval { dt_from_string( $input->param('no_auto_renewal_after_hard_limit') ) } if ( $no_auto_renewal_after_hard_limit );
>+    $no_auto_renewal_after_hard_limit = eval { dt_from_string( $no_auto_renewal_after_hard_limit ) } if ( $no_auto_renewal_after_hard_limit );
>     $no_auto_renewal_after_hard_limit = output_pref( { dt => $no_auto_renewal_after_hard_limit, dateonly => 1, dateformat => 'iso' } ) if ( $no_auto_renewal_after_hard_limit );
>     my $reservesallowed  = strip_non_numeric($input->param('reservesallowed'));
>     my $holds_per_record = strip_non_numeric($input->param('holds_per_record'));
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25440: 104635 | 104636 | 104637 | 104638 | 104639 | 104640 | 105059 | 105063 | 105985 | 106300 | 106301 | 106302 | 106303 | 106304 | 106305 | 106388