Bugzilla – Attachment 106306 Details for
Bug 25491
Perl warning at the login page of installer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
Bug-25491-Fix-for-Use-of-uninitialized-value-in-In.patch (text/plain), 1.48 KB, created by
Martin Renvoize (ashimema)
on 2020-06-25 14:44:53 UTC
(
hide
)
Description:
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-06-25 14:44:53 UTC
Size:
1.48 KB
patch
obsolete
>From 5faa71da3856d46cea88200bfe6c2dbaa1a6555c Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Wed, 13 May 2020 20:20:27 +0300 >Subject: [PATCH] Bug 25491: Fix for "Use of uninitialized value" in > InstallAuth.pm > >This warning was thrown: > Use of uninitialized value $info{"invalid_username_or_password"} > in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm > line 387. > >There is the case when hash key can be undefined in numeric comparison. > >Fixed by adding additional precheck for >$info{"invalid_username_or_password"} being Perl's "true". > >To test: > 1) Go to the first page of the web-installer where it asks to login. > 2) Observe the warning in the log file. > 3) Apply patch. > 4) Repeat step 1. > 7) Check that previous warning suppressed. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/InstallAuth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/InstallAuth.pm b/C4/InstallAuth.pm >index 987045df50..2c866b22eb 100644 >--- a/C4/InstallAuth.pm >+++ b/C4/InstallAuth.pm >@@ -384,7 +384,7 @@ sub checkauth { > $template->param( login => 1 ); > $template->param( loginprompt => 1 ) unless $info{'nopermission'}; > >- if ($info{'invalid_username_or_password'} == 1) { >+ if ($info{'invalid_username_or_password'} && $info{'invalid_username_or_password'} == 1) { > $template->param( 'invalid_username_or_password' => $info{'invalid_username_or_password'}); > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25491
:
104851
|
106306
|
106308