Bugzilla – Attachment 106309 Details for
Bug 25874
Explicit return of undef in C4/CourseReserves.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25874: Explicit return of undef in C4/CourseReserves.pm
Bug-25874-Explicit-return-of-undef-in-C4CourseRese.patch (text/plain), 1.07 KB, created by
Kyle M Hall (khall)
on 2020-06-25 16:15:26 UTC
(
hide
)
Description:
Bug 25874: Explicit return of undef in C4/CourseReserves.pm
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-06-25 16:15:26 UTC
Size:
1.07 KB
patch
obsolete
>From dca258348501f306e95a76c782dafd957d961a39 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 25 Jun 2020 12:13:59 -0400 >Subject: [PATCH] Bug 25874: Explicit return of undef in C4/CourseReserves.pm > >"return" statement with explicit "undef" at line 87, column 5. See page 199 of PBP. (Severity: 5) > >Test Plan: >1) perlcritic C4/CourseReserves.pm > "return" statement with explicit "undef" at line 87, column 5. See page 199 of PBP. (Severity: 5) >2) Apply this patch >3) perlcritic C4/CourseReserves.pm > C4/CourseReserves.pm source OK >--- > C4/CourseReserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm >index beb45285df..1c08ad4d5e 100644 >--- a/C4/CourseReserves.pm >+++ b/C4/CourseReserves.pm >@@ -84,7 +84,7 @@ sub GetCourse { > warn whoami() . "( $course_id )" if $DEBUG; > > my $course = Koha::Courses->find( $course_id ); >- return undef unless $course; >+ return unless $course; > $course = $course->unblessed; > > my $dbh = C4::Context->dbh; >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25874
: 106309