Attachment 106531 Details for Bug 25827 – Bug 25827: Add floating toolbar to the holds summary page in staff interface

[patch] Bug 25827: Add floating toolbar to the holds summary page in staff interface

Bug-25827-Add-floating-toolbar-to-the-holds-summar.patch (text/plain), 3.26 KB, created by Katrin Fischer on 2020-07-04 23:02:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-07-04 23:02:33 UTC

Size: 3.26 KB

patch

obsolete

>From 5d27f8d86a7b2cbb24d9a120c3e6625fbe65e4d5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 29 Jun 2020 15:08:47 +0000
>Subject: [PATCH] Bug 25827: Add floating toolbar to the holds summary page in
> staff interface
>
>This patch adds a floating toolbar to the holds summary page in the staff
>interface.
>
>To test, apply the patch and view the holds page for a title with
>multiple holds on it. Test that when you scroll down past the position
>of the "Update hold(s)" button, the toolbar "sticks" to the top of the
>screen.
>
>Test that holds are updated correctly after clicking the "Update
>hold(s)" button.
>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/reserve/request.tt    | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 1795eed1c0..50b95faef0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -789,12 +789,15 @@
> 
>             [% UNLESS ( patron ) %]
>                 [% IF ( reserveloop ) %]
>-                    <form name="T[% time | html %]" action="modrequest.pl" method="post">
>+                    <form id="existing_holds" name="T[% time | html %]" action="modrequest.pl" method="post" style="display:block">
>                         [% IF ( multi_hold ) %]
>                             <input type = "hidden" name="biblionumbers" value="[% biblionumbers | html %]"/>
>                         [% END %]
> 
>                         <h2>Existing holds</h2>
>+                        <div id="toolbar" class="btn-toolbar">
>+                            <input type="submit" name="submit" value="Update hold(s)" />
>+                        </div>
> 
>                         [% FOREACH biblioloo IN biblioloop %]
>                             [% IF ( biblioloo.reserveloop ) %]
>@@ -902,10 +905,6 @@
> 
>                             [% END # /IF biblioloo.reserveloop %]
>                         [% END # FOREACH biblioloo %]
>-
>-                        <fieldset class="action">
>-                            <input type="submit" name="submit" value="Update hold(s)" />
>-                        </fieldset>
>                     </form> 
>                 [% END # IF reserveloop %]
>             [% END # UNLESS patron %]
>@@ -929,8 +928,10 @@
>     [% INCLUDE 'datatables.inc' %]
>     [% INCLUDE 'calendar.inc' %]
>     [% INCLUDE 'columns_settings.inc' %]
>+    [% Asset.js("lib/hc-sticky.js") | $raw %]
>     [% Asset.js("js/circ-patron-search-results.js") | $raw %]
>     <script>
>+        var Sticky;
>         var biblionumber = "[% biblionumber | $raw %]";
>         var borrowernumber = "[% patron.borrowernumber | $raw %]";
>         var MSG_CONFIRM_DELETE_HOLD   = _("Are you sure you want to cancel this hold?");
>@@ -1245,7 +1246,11 @@
>                 };
>                 [% END %]
>             [% END %]
>-
>+            Sticky = $("#toolbar");
>+            Sticky.hcSticky({
>+                stickTo: "#existing_holds",
>+                stickyClass: "floating"
>+            });
>         });
>     </script>
> [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25827: 106405 | 106482 | 106489 | 106531