Attachment 106563 Details for Bug 23820 – Bug 23820: (QA follow-up) Make label clickable for checkbox

[patch] Bug 23820: (QA follow-up) Make label clickable for checkbox

Bug-23820-QA-follow-up-Make-label-clickable-for-ch.patch (text/plain), 1.51 KB, created by Katrin Fischer on 2020-07-05 19:11:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-07-05 19:11:21 UTC

Size: 1.51 KB

patch

obsolete

>From 55844597ebd14149c69ec5bef536cf310994bebf Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 1 Jul 2020 11:30:18 +0000
>Subject: [PATCH] Bug 23820: (QA follow-up) Make label clickable for checkbox
>
>By adding an id the checkbox is selected when the label is clicked
>enhancing usability.
>
>Also adds a colon : to the label.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 8473127a39..c266fe120f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -163,8 +163,8 @@
>                                 </select>
>                             </li>
>                             <li>
>-                                <label for="default_patron_home">Pickup at patron's home library when possible</label>
>-                                <input type="checkbox" name="default_patron_home"/>
>+                                <label for="default_patron_home">Pickup at patron's home library when possible:</label>
>+                                <input type="checkbox" id="default_patron_home" name="default_patron_home"/>
>                             </li>
>                         </ol>
>                         <h2 style="padding: 0 1em;">Members</h2>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23820: 102093 | 102153 | 105437 | 106561 | 106562 | 106563 | 107128