Attachment 10661 Details for Bug 5327 – added date and ISBN tests to Koha.t

[patch] added date and ISBN tests to Koha.t

added-date-and-ISBN-tests-to-Kohat.patch (text/plain), 3.17 KB, created by Mason James on 2012-07-06 04:21:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2012-07-06 04:21:52 UTC

Size: 3.17 KB

patch

obsolete

>From ced77bfa4897f7ece084a6e9be037f04b3cbb7c0 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Fri, 6 Jul 2012 16:19:51 +1200
>Subject: [PATCH] added date and ISBN tests to Koha.t
>Content-Type: text/plain; charset="utf-8"
>http://koha-community.org
>
>modified:   Koha.t
>
>$ prove  -v ./Koha.t
>
>1..5
>ok 1 - use C4::Koha;
>ok 2 - use C4::Members;
>    1..6
>    ok 1 - Insert data in database
>    ok 2 - GetAuthorisedValueByCode
>    ok 3 - GetKohaImageurlFromAuthorisedValues
>    ok 4 - lost and paid works
>    ok 5 - Child area works
>    ok 6 - Withdrawn works
>ok 3 - Authorized Values Tests
>    1..4
>    ok 1 - C4::Koha->can('GetDailyQuote')
>    ok 2 - Got a quote based on id.
>    ok 3 - Got a random quote.
>    ok 4 - Got a quote based on today's date.
>ok 4 - Daily Quotes Test
>    1..7
>    ok 1 - slashifyDate
>    ok 2 - xml_escape() returns empty string on undef input
>    ok 3 - xml_escape() works as expected
>    ok 4 - ... and does not change input in place
>    ok 5 - _isbn_cleanup removes hyphens
>    ok 6 - _isbn_cleanup removes parenthetical
>    ok 7 - _isbn_cleanup converts ISBN-13 to ISBN-10
>ok 5 - Date and ISBN tests
>ok
>All tests successful.
>Files=1, Tests=5,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.48 cusr  0.06 csys =  0.57 CPU)
>Result: PASS
>
>http://bugs.koha-community.org/show_bug.cgi?id=5327
>---
> t/db_dependent/Koha.t |   51 ++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 50 insertions(+), 1 deletions(-)
>
>diff --git a/t/db_dependent/Koha.t b/t/db_dependent/Koha.t
>index e53e936..fc5da4e 100644
>--- a/t/db_dependent/Koha.t
>+++ b/t/db_dependent/Koha.t
>@@ -7,7 +7,7 @@ use strict;
> use warnings;
> use C4::Context;
> 
>-use Test::More tests => 4;
>+use Test::More tests => 5;
> use DateTime::Format::MySQL;
> 
> eval {use Test::Deep;};
>@@ -62,6 +62,21 @@ subtest 'Authorized Values Tests' => sub {
>         $sth->execute($data->{category}, $data->{authorised_value}, $data->{lib}, $data->{lib_opac}, $data->{imageurl});
>     }
> };
>+
>+
>+
>+
>+
>+
>+
>+
>+
>+
>+
>+
>+
>+
>+
> ### test for C4::Koha->GetDailyQuote()
> SKIP:
>     {
>@@ -109,3 +124,37 @@ SKIP:
>             }
>         };
> }
>+
>+
>+#
>+# test that &slashifyDate returns correct (non-US) date
>+#
>+subtest 'Date and ISBN tests' => sub {
>+    plan tests => 7;
>+
>+    my $date    = "01/01/2002";
>+    my $newdate = &slashifyDate("2002-01-01");
>+    my $isbn13  = "9780330356473";
>+    my $isbn13D = "978-0-330-35647-3";
>+    my $isbn10  = "033035647X";
>+    my $isbn10D = "0-330-35647-X";
>+    ok( $date eq $newdate, 'slashifyDate' );
>+    my $undef = undef;
>+    is( xml_escape($undef), '',
>+        'xml_escape() returns empty string on undef input' );
>+    my $str = q{'"&<>'};
>+    is(
>+        xml_escape($str),
>+        '&apos;&quot;&amp;&lt;&gt;&apos;',
>+        'xml_escape() works as expected'
>+    );
>+    is( $str, q{'"&<>'}, '... and does not change input in place' );
>+    is( C4::Koha::_isbn_cleanup('0-590-35340-3'),
>+        '0590353403', '_isbn_cleanup removes hyphens' );
>+    is( C4::Koha::_isbn_cleanup('0590353403 (pbk.)'),
>+        '0590353403', '_isbn_cleanup removes parenthetical' );
>+    is( C4::Koha::_isbn_cleanup('978-0-321-49694-2'),
>+        '0321496949', '_isbn_cleanup converts ISBN-13 to ISBN-10' );
>+
>+};
>+
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 5327: 2716 | 2726 | 5485 | 6236 | 6237 | 6373 | 6560 | 6561 | 6562 | 6563 | 6613 | 6614 | 6616 | 6620 | 6621 | 6622 | 6643 | 6650 | 6655 | 6679 | 6681 | 6682 | 6683 | 6726 | 6727 | 6728 | 6729 | 6730 | 6731 | 6732 | 6795 | 6799 | 6805 | 6819 | 6826 | 6827 | 6828 | 6834 | 7179 | 7180 | 7181 | 7182 | 7183 | 7184 | 7185 | 7186 | 7187 | 7188 | 7189 | 7190 | 7191 | 7192 | 7194 | 7195 | 7203 | 7206 | 7208 | 7209 | 7220 | 7221 | 7222 | 7223 | 7224 | 7225 | 7226 | 7227 | 7228 | 7229 | 7230 | 7231 | 7232 | 7233 | 7234 | 7235 | 7236 | 7237 | 7238 | 7239 | 7240 | 7241 | 7242 | 7400 | 7402 | 7403 | 7405 | 7573 | 7592 | 7593 | 7594 | 9897 | 10234 | 10616 | 10656 | 10659 | 10660 | 10661 | 10680 | 11141 | 11186 | 11212 | 11213 | 11278 | 11279 | 11280 | 11281 | 11339 | 11340 | 11341 | 11440 | 11467 | 11469 | 11470 | 11471 | 11472 | 11473 | 11500 | 11503 | 11505 | 11506 | 11633 | 11762 | 11763 | 11764 | 11765 | 11846 | 11985 | 11993 | 12002 | 12003