Bugzilla – Attachment 106633 Details for
Bug 25798
Copyright year to Holds to pull report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25798: Add copyright year to "Holds to pull" report
Bug-25798-Add-copyright-year-to-Holds-to-pull-repo.patch (text/plain), 2.85 KB, created by
Owen Leonard
on 2020-07-07 13:48:26 UTC
(
hide
)
Description:
Bug 25798: Add copyright year to "Holds to pull" report
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-07-07 13:48:26 UTC
Size:
2.85 KB
patch
obsolete
>From 6d7fa648ce127726cd401361b5f497d0cf8a44fe Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Sat, 27 Jun 2020 00:06:47 +0300 >Subject: [PATCH] Bug 25798: Add copyright year to "Holds to pull" report > >Display copyright year (publication year) of book >together with title in "Holds to pull" report. > >Copyright year is fetched from biblio -table as "copyrightyear" >and displayed when the preferred marc is set to MARC21. >Publication year is fetched from biblioitems -table as "publicationyear" >and displayed when the preferred marc is set to UNIMARC. > >1. Place a hold on book with known copyright year. >2. Go to /cgi-bin/koha/circ/pendingreserves.pl and check the "title" >table of that book that you placed hold on. >3. Observe that there's no information about publication year in that >field. >4. Apply patch. >5. Repeat step 2. >6. Observe that copyright year (publication year) of book appeared >in the title table after book's title and author. > >Mentored-by: Andrew Nugged <nugged@gmail.com> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > circ/pendingreserves.pl | 3 +++ > koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 1 + > 2 files changed, 4 insertions(+) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 22c93f7130..0417dfa89a 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -201,6 +201,8 @@ my $strsth = > GROUP_CONCAT(DISTINCT items.copynumber > ORDER BY items.itemnumber SEPARATOR '|') l_copynumber, > biblio.title, >+ biblio.copyrightdate, >+ biblioitems.publicationyear, > biblio.subtitle, > biblio.medium, > biblio.part_number, >@@ -273,6 +275,7 @@ while ( my $data = $sth->fetchrow_hashref ) { > holdingbranch => $data->{holdingbranch}, > homebranch => $data->{homebranch}, > itemnumber => $data->{itemnumber}, >+ publicationyear => C4::Context->preference('marcflavour') eq "MARC21" ? $data->{copyrightdate} : $data->{publicationyear}, > } > ); > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 7783acc707..af6c8114ff 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -81,6 +81,7 @@ > </a></p> > [% IF ( reserveloo.author ) %]<p> by [% reserveloo.author | html %]</p>[% END %] > [% IF ( reserveloo.editionstatement ) %]<p>[% reserveloo.editionstatement | html %]</p>[% END %] >+ [% IF ( reserveloo.publicationyear ) %]<p>[% reserveloo.publicationyear | html %]</p>[% END %] > </td> > [% ELSE %] > <td>"</td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25798
:
106167
|
106354
|
106633
|
107069