Attachment 106758 Details for Bug 25969 – Bug 25969: Checking in a found hold at a different branch then confirming the hold causes internal server error

[patch] Bug 25969: Checking in a found hold at a different branch then confirming the hold causes internal server error

Bug-25969-Checking-in-a-found-hold-at-a-different-.patch (text/plain), 1.40 KB, created by Kyle M Hall (khall) on 2020-07-09 18:39:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-07-09 18:39:55 UTC

Size: 1.40 KB

patch

obsolete

>From b22467381117e8f3c63d15729f916dc1fd381f80 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 9 Jul 2020 14:36:31 -0400
>Subject: [PATCH] Bug 25969: Checking in a found hold at a different branch
> then confirming the hold causes internal server error
>
>If a record level hold is filled and waiting at Library A, and the item
>is checked in at Library B, and an attempt is made to re-fill the hold
>with the item, Koha will return an ISE.
>
>Test Plan:
>1) Place a hold for Library A, at Library A, for pickup at Library A
>2) Check in the item at Library A and fill the hold so it is waiting at Library A
>3) Log in as Library B, check in the same barcode
>4) Note the request to fill the hold with the item
>5) Choose to fill the hold
>6) Note you get an internal server error
>7) Apply this patch
>8) Restart all the things!
>9) Repeat steps 1-5
>10) No ISE!
>---
> circ/returns.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 557fadc274..4dd834406f 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -427,6 +427,7 @@ if ( $messages->{'ResFound'}) {
>             hold_auto_filled => 1,
>             print_slip       => C4::Context->preference('HoldsAutoFillPrintSlip'),
>             reserve_id       => $nextreservinfo->{reserve_id},
>+            itemnumber       => $itemumber,
>         );
> 
>         if ( $messages->{'transfert'} ) {
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 25969: 106758 | 106771 | 107697 | 109678 | 109755 | 109756 | 110006 | 110007 | 111328 | 111344