Attachment 106778 Details for Bug 22806 – Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions

[patch] Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions

Bug-22806-CanBookBeReserved-and-CanItemBeReserved-.patch (text/plain), 2.21 KB, created by David Nind on 2020-07-11 07:31:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-07-11 07:31:28 UTC

Size: 2.21 KB

patch

obsolete

>From 4de880bae30255f69cd2bfeaa94d2cd55e75186c Mon Sep 17 00:00:00 2001
>From: Arthur Suzuki <arthur.suzuki@biblibre.com>
>Date: Tue, 14 May 2019 02:30:26 +0200
>Subject: [PATCH] Bug 22806: CanBookBeReserved and CanItemBeReserved must check
> AllowHoldsOnPatronsPossessions
>
>Test plan :
>1 - set AllowHoldsOnPatronsPossessions to "Don't Allow"
>2 - Checkout an item to a borrower
>3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining.
>4 - Cancel the hold and apply patch
>5 - Repeat 3 -> Should not place hold and show error "NotHoldable"
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/Reserves.pm | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 2c17d53235..63b62dea01 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -311,6 +311,12 @@ See CanItemBeReserved() for possible return values.
> sub CanBookBeReserved{
>     my ($borrowernumber, $biblionumber, $pickup_branchcode) = @_;
> 
>+    # Check that patron have not checked out this biblio (if AllowHoldsOnPatronsPossessions set)
>+    if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
>+        && C4::Circulation::CheckIfIssuedToPatron( $patron->borrowernumber, $biblio->biblionumber ) ) {
>+        return { status =>'itemAlreadyOnLoan' };
>+    }
>+
>     my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber");
>     #get items linked via host records
>     my @hostitems = get_hostitemnumbers_of($biblionumber);
>@@ -375,6 +381,12 @@ sub CanItemBeReserved {
>     return { status =>'itemAlreadyOnHold' }
>       if Koha::Holds->search( { borrowernumber => $borrowernumber, itemnumber => $itemnumber } )->count();
> 
>+    # Check that patron have not checked out this biblio (if AllowHoldsOnPatronsPossessions set)
>+    if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
>+        && C4::Circulation::CheckIfIssuedToPatron( $patron->borrowernumber, $biblio->biblionumber ) ) {
>+        return { status =>'itemAlreadyOnLoan' };
>+    }
>+
>     my $controlbranch = C4::Context->preference('ReservesControlBranch');
> 
>     my $querycount = q{
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22806: 89039 | 89724 | 91784 | 94388 | 94389 | 97947 | 99881 | 99882 | 99883 | 99884 | 99885 | 100091 | 100092 | 100093 | 100173 | 100174 | 100175 | 106564 | 106778 | 106779 | 106780 | 107760 | 107806 | 110100 | 110101 | 110102 | 110973 | 110974 | 110975 | 110976 | 111771 | 111772 | 111773 | 111774 | 112824