Attachment 106850 Details for Bug 25944 – Bug 25944: Schema fix for illrequests route

[patch] Bug 25944: Schema fix for illrequests route

Bug-25944-Schema-fix-for-illrequests-route.patch (text/plain), 1.68 KB, created by Tomás Cohen Arazi (tcohen) on 2020-07-13 18:54:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-07-13 18:54:13 UTC

Size: 1.68 KB

patch

obsolete

>From 59cf206d99a12c6ea38ee7b92961587748b3789e Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 7 Jul 2020 09:27:48 +0100
>Subject: [PATCH] Bug 25944: Schema fix for illrequests route
>
>The illrequests path was missing the `comments` and `status_alias`
>embedable relations in the path specification.
>
>Test plan:
>1/ Ensure you have the latest Mojolicious + OpenAPI modules installed.
>2/ Navigate to the ill requests page and note that the table is empty.
>3/ Note that under the networking tab in your browsers developer tools
>that the api call fails with a 400 error.
>4/ Apply the patch
>5/ Refresh the page
>6/ The table should now load and the api route should return a proper
>200 response.
>7/ Signoff
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Applied the patch to a production server that was having the 400
>error on the main ILL page, and the error was gone.
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> api/v1/swagger/paths/illrequests.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/api/v1/swagger/paths/illrequests.json b/api/v1/swagger/paths/illrequests.json
>index 0fc13e9007b..c800c05bcaf 100644
>--- a/api/v1/swagger/paths/illrequests.json
>+++ b/api/v1/swagger/paths/illrequests.json
>@@ -18,7 +18,9 @@
>                         "library",
>                         "capabilities",
>                         "metadata",
>-                        "requested_partners"
>+                        "requested_partners",
>+                        "comments",
>+                        "status_alias"
>                     ]
>                 }
>             }, {
>-- 
>2.27.0

Actions: View | Diff | Splinter Review

Attachments on bug 25944: 106631 | 106849 | 106850