Bugzilla – Attachment 106888 Details for
Bug 25987
Radio buttons are misaligned in New label batches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25987: Fix alignment of fields in label batch creation form
Bug-25987-Fix-alignment-of-fields-in-label-batch-c.patch (text/plain), 4.47 KB, created by
Katrin Fischer
on 2020-07-15 05:47:09 UTC
(
hide
)
Description:
Bug 25987: Fix alignment of fields in label batch creation form
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-07-15 05:47:09 UTC
Size:
4.47 KB
patch
obsolete
>From c26a6a9ba74487cec7e54bf524982abaa6ad5002 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 14 Jul 2020 21:30:39 +0000 >Subject: [PATCH] Bug 25987: Fix alignment of fields in label batch creation > form > >This patch makes minor markup changes to the template for the label >batch creation process so that form fields line up correctly. > >Unrelated change: A hint has been moved out of the label area to below >the textarea in order to conform with established patterns. > >To test, apply the patch and go to Tools > Label creator > New > Label >batch. > > - In the batch creation form the "Enter by itemnumber" and "Enter by > barcode" should be aligned correctly with each other. > - The "One number per line..." hint should appear below the textarea. > - Test that the form fields are still correctly aligned after adding > some items to the batch and the "description" field is shown in the > form. > >Works for me! > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/labels/label-edit-batch.tt | 23 +++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >index 27282a95b9..24b3de3e4b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt >@@ -62,23 +62,28 @@ > <div> > <fieldset class="rows" style="border-bottom: 0px; border: 0px;"> > <ol><li id="description"> >- <input type="hidden" name="op" value="add" /> >- <input type="hidden" name="batch_id" value="[% batch_id | html %]" /> >- <label for="description">Batch description: </label> >- <input type="text" name="description" value="[% description | html %]"> <span id="change-status"></span> >- </li> >+ <input type="hidden" name="op" value="add" /> >+ <input type="hidden" name="batch_id" value="[% batch_id | html %]" /> >+ <label for="description">Batch description: </label> >+ <input type="text" name="description" value="[% description | html %]"> <span id="change-status"></span> >+ </li> > <li> > <input type="radio" name="number_type" id="barcode_enter" value="barcode" checked /> >- <label for="barcode_enter">Enter by barcode:</label><br/> >+ <label for="barcode_enter">Enter by barcode:</label> >+ </li> >+ <li> > <input type="radio" name="number_type" id="itemnum_enter" value="itemnumber" /> > <label for="itemnum_enter">Enter by itemnumber:</label> > </li> > <li> >- <label for="number_list">Add by barcode(s) or itemnumbers(s): >- <br /> <span class="hint">One number per line.</span> >- <br /> <span class="hint">Leave empty to add via item search (itemnumber).</span> >+ <label for="number_list"> >+ Add by barcode(s) or itemnumbers(s): > </label> > <textarea rows="5" id="number_list" name="number_list" tabindex="1" class="focus"></textarea> >+ <div class="hint"> >+ One number per line. >+ <br /> Leave empty to add via item search (itemnumber) >+ </div> > </li></ol> > </fieldset> > </div> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25987
:
106880
|
106881
| 106888