Attachment 107109 Details for Bug 25244 – Bug 25244: Add specific aria-label to search results

[patch] Bug 25244: Add specific aria-label to search results

Bug-25244-Add-specific-aria-label-to-search-result.patch (text/plain), 4.58 KB, created by Jonathan Druart on 2020-07-20 14:51:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-07-20 14:51:02 UTC

Size: 4.58 KB

patch

obsolete

>From e78640253c902a95a120af734caee2fd53e58005 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 29 Jun 2020 15:55:17 +0100
>Subject: [PATCH] Bug 25244: Add specific aria-label to search results
>
>This patch adds an arai-lebel to the select checkboxes on the search
>results page of the OPAC.
>
>Test plan
>1/ Perform a search that will yield some results
>2/ Inspect the 'checkbox' on the left side of the results table
>3/ Note that there is no arai-label
>4/ Apply patch
>5/ Refresh the search results page
>6/ Inspect the 'checkbox' on the left side of the results table
>7/ Note that the aria-label now appears and contains relavant
>information
>8/ Signoff
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>
>Bug 25244: (follow-up) QA corrections
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-results.tt    | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index b9d1423378..3fd522cf62 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -239,16 +239,21 @@
>                                     [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %]
>                                         <tr>
>                                             [% # Cell 1: Checkbox %]
>+                                            [% IF ( SEARCH_RESULT.title ) %]
>+                                                [% check_title = SEARCH_RESULT.title %]
>+                                            [% ELSE %]
>+                                                [% check_title = SEARCH_RESULT.biblionumber %]
>+                                            [% END %]
>                                             <td class="select selectcol">
>                                                 [% IF Koha.Preference( 'opacbookbag' ) == 1 %]
>-                                                    <input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" /> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label>
>+                                                    <input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" aria-label="Select search result: [% check_title | html %]" /> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label>
>                                                 [% ELSE %]
>                                                     [% IF Koha.Preference( 'virtualshelves' ) == 1 %]
>-                                                        <input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" /> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label>
>+                                                        <input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" aria-label="Select search result: [% check_title | html %]"/> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label>
>                                                     [% ELSE %]
>                                                         [% IF Koha.Preference( 'RequestOnOpac' ) == 1 %]
>                                                             [% UNLESS ( SEARCH_RESULT.norequests ) %]
>-                                                                [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]<input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" /> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label>
>+                                                                [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]<input type="checkbox" class="cb" id="bib[% SEARCH_RESULT.biblionumber | html %]" name="biblionumber" value="[% SEARCH_RESULT.biblionumber | html %]" aria-label="Select search result: [% check_title | html %]"/> <label for="bib[% SEARCH_RESULT.biblionumber | html %]"></label>
>                                                                 [% END %]
>                                                             [% END %]
>                                                         [% END # IF RequestOnOpac %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25244: 106404 | 106406 | 106499 | 106500 | 106511 | 106512 | 107109