Attachment 107121 Details for Bug 23391 – Bug 23391: Remove warnings

[patch] Bug 23391: Remove warnings

Bug-23391-Remove-warnings.patch (text/plain), 1.50 KB, created by Jonathan Druart on 2020-07-20 15:45:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-07-20 15:45:07 UTC

Size: 1.50 KB

patch

obsolete

>From c698ef0a74aea6a6846269255127991a39e9fbd4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 20 Jul 2020 17:44:40 +0200
>Subject: [PATCH] Bug 23391: Remove warnings
>
>t/db_dependent/api/v1/illrequests.t .. Use of uninitialized value $hidden_statuses_string in split at /kohadevbox/koha/Koha/REST/V1/Illrequests.pm line 61.
>Use of uninitialized value $hidden_statuses_string in split at /kohadevbox/koha/Koha/REST/V1/Illrequests.pm line 61.
>Use of uninitialized value $hidden_statuses_string in split at /kohadevbox/koha/Koha/REST/V1/Illrequests.pm line 61.
>Use of uninitialized value $hidden_statuses_string in split at /kohadevbox/koha/Koha/REST/V1/Illrequests.pm line 61.
>Use of uninitialized value $hidden_statuses_string in split at /kohadevbox/koha/Koha/REST/V1/Illrequests.pm line 61.
>t/db_dependent/api/v1/illrequests.t .. ok
>---
> Koha/REST/V1/Illrequests.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm
>index 2274c591ef..24f93cbffa 100644
>--- a/Koha/REST/V1/Illrequests.pm
>+++ b/Koha/REST/V1/Illrequests.pm
>@@ -56,7 +56,7 @@ sub list {
>     }
> 
>     # Get the pipe-separated string of hidden ILL statuses
>-    my $hidden_statuses_string = C4::Context->preference('ILLHiddenRequestStatuses');
>+    my $hidden_statuses_string = C4::Context->preference('ILLHiddenRequestStatuses') // q{};
>     # Turn into arrayref
>     my $hidden_statuses = [ split /\|/, $hidden_statuses_string ];
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23391: 96222 | 98390 | 98391 | 106411 | 106599 | 107121