Bugzilla – Attachment 107128 Details for
Bug 23820
Club hold pickup locations should be able to default to patron's home library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23820: Fix Koha/Club/Hold.t
Bug-23820-Fix-KohaClubHoldt.patch (text/plain), 1.47 KB, created by
Jonathan Druart
on 2020-07-21 08:08:42 UTC
(
hide
)
Description:
Bug 23820: Fix Koha/Club/Hold.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-07-21 08:08:42 UTC
Size:
1.47 KB
patch
obsolete
>From 643e1fbffdfd6e4f0f24c86219015ae825631e26 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Jul 2020 10:08:02 +0200 >Subject: [PATCH] Bug 23820: Fix Koha/Club/Hold.t > >kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Club/Hold.t >t/db_dependent/Koha/Club/Hold.t .. Patron(238) Hold cannot be placed. Reason: libraryNotPickupLocation at /kohadevbox/koha/Koha/Club/Hold.pm line 98. > # Looks like you planned 5 tests but ran 4. >t/db_dependent/Koha/Club/Hold.t .. 1/1 > # Failed test 'add' > # at t/db_dependent/Koha/Club/Hold.t line 86. >Can't call method "borrowernumber" on an undefined value at t/db_dependent/Koha/Club/Hold.t line 83. >--- > t/db_dependent/Koha/Club/Hold.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Club/Hold.t b/t/db_dependent/Koha/Club/Hold.t >index 6aee1e4dcf..8bc7f5811d 100644 >--- a/t/db_dependent/Koha/Club/Hold.t >+++ b/t/db_dependent/Koha/Club/Hold.t >@@ -41,7 +41,7 @@ subtest 'add' => sub { > $schema->storage->txn_begin; > > my $club = $builder->build_object({ class => 'Koha::Clubs' }); >- my $library = $builder->build_object({ class => 'Koha::Libraries' }); >+ my $library = $builder->build_object({ class => 'Koha::Libraries', value => { pickup_location => 1 } }); > my $item1 = $builder->build_sample_item({ library => $library->branchcode }); > my $item2 = $builder->build_sample_item({ library => $library->branchcode }); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23820
:
102093
|
102153
|
105437
|
106561
|
106562
|
106563
| 107128