Attachment 10715 Details for Bug 8392 – Proposed patch

[patch] Proposed patch

0001-Bug-8392-Category-age-ranges-not-being-enforced.patch (text/plain), 1.47 KB, created by D Ruth Holloway on 2012-07-09 14:21:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: D Ruth Holloway

Created: 2012-07-09 14:21:46 UTC

Size: 1.47 KB

patch

obsolete

>From 1c25a1130adb2717495b99c1726b3d782b193db3 Mon Sep 17 00:00:00 2001
>From: D Ruth Bavousett <ruth@bywatersolutions.com>
>Date: Mon, 9 Jul 2012 10:18:03 -0400
>Subject: [PATCH] Bug 8392: Category age ranges not being enforced
>
>This patch works around the redefinition of an array that was causing the enforcement of
>age ranges to not-happen.
>---
> members/memberentry.pl |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 58f5cf1..0cf5485 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -101,6 +101,8 @@ my @field_check=split(/\|/,$check_BorrowerMandatoryField);
> foreach (@field_check) {
> 	$template->param( "mandatory$_" => 1);    
> }
>+# we'll need this, later.
>+my $dateofbirthmandatory = (scalar grep {$_ eq "dateofbirth"} @field_check) ? 1 : 0;
> # function to designate unwanted fields
> my $check_BorrowerUnwantedField=C4::Context->preference("BorrowerUnwantedField");
> @field_check=split(/\|/,$check_BorrowerUnwantedField);
>@@ -264,7 +266,6 @@ if ($op eq 'save' || $op eq 'insert'){
>     if (checkcardnumber($newdata{cardnumber},$newdata{borrowernumber})){ 
>         push @errors, 'ERROR_cardnumber';
>     } 
>-    my $dateofbirthmandatory = (scalar grep {$_ eq "dateofbirth"} @field_check) ? 1 : 0;
>     if ($newdata{dateofbirth} && $dateofbirthmandatory) {
>         my $age = GetAge($newdata{dateofbirth});
>         my $borrowercategory=GetBorrowercategory($newdata{'categorycode'});   
>-- 
>1.7.2.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 8392: 10715 | 10718 | 10719 | 10983