Attachment 107168 Details for Bug 5087 – Bug 5087: (QA follow-up) used_for deserves an index

[patch] Bug 5087: (QA follow-up) used_for deserves an index

Bug-5087-QA-follow-up-usedfor-deserves-an-index.patch (text/plain), 1.85 KB, created by Tomás Cohen Arazi (tcohen) on 2020-07-21 17:17:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-07-21 17:17:22 UTC

Size: 1.85 KB

patch

obsolete

>From a854cad913f5f716e308491f5b437d0c184143c4 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 20 Jul 2020 11:27:27 -0300
>Subject: [PATCH] Bug 5087: (QA follow-up) used_for deserves an index
>
>This patch introduces an index for the used_for column
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> ...bug_5087_-_add_opac_option_field_to_export_formats.perl | 7 +++++++
> installer/data/mysql/kohastructure.sql                     | 1 +
> 2 files changed, 8 insertions(+)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_5087_-_add_opac_option_field_to_export_formats.perl b/installer/data/mysql/atomicupdate/bug_5087_-_add_opac_option_field_to_export_formats.perl
>index 7eaffd409d..41ee9459f4 100644
>--- a/installer/data/mysql/atomicupdate/bug_5087_-_add_opac_option_field_to_export_formats.perl
>+++ b/installer/data/mysql/atomicupdate/bug_5087_-_add_opac_option_field_to_export_formats.perl
>@@ -8,5 +8,12 @@ if( CheckVersion( $DBversion ) ) {
>         |);
>     }
> 
>+    unless ( index_exists( 'export_format', 'used_for_idx' ) ) {
>+        $dbh->do(q|
>+            ALTER TABLE export_format
>+                ADD KEY `used_for_idx` (`used_for` (191));
>+        |);
>+    }
>+
>     NewVersion( $DBversion, 5087, "Add export_format.staff_only" );
> }
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 456f7b1134..49cdb3bc33 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -693,6 +693,7 @@ CREATE TABLE `export_format` (
>   `used_for` varchar(255) DEFAULT 'export_records',
>   `staff_only` TINYINT(1) NOT NULL DEFAULT 0,
>   PRIMARY KEY (`export_format_id`),
>+  KEY `used_for_idx` (`used_for` (191)),
>   KEY `staff_only_idx` (`staff_only`)
> ) ENGINE=InnoDB  DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci COMMENT='Used for CSV export';
> 
>-- 
>2.27.0

Actions: View | Diff | Splinter Review

Attachments on bug 5087: 2450 | 83438 | 83664 | 98779 | 103437 | 103506 | 103955 | 107111 | 107112 | 107113 | 107114 | 107166 | 107167 | 107168 | 107169 | 107224