Attachment 107184 Details for Bug 12556 – Bug 12556: reserves/request.pl: Reuse code from Koha::Hold

[patch] Bug 12556: reserves/request.pl: Reuse code from Koha::Hold

Bug-12556-reservesrequestpl-Reuse-code-from-KohaHo.patch (text/plain), 1.57 KB, created by Joonas Kylmälä on 2020-07-22 15:50:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2020-07-22 15:50:23 UTC

Size: 1.57 KB

patch

obsolete

>From 3a19bbe7c47b05615eee9bf6b163173cb0b6d683 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Wed, 22 Jul 2020 15:44:31 +0000
>Subject: [PATCH] Bug 12556: reserves/request.pl: Reuse code from Koha::Hold
>
>---
> reserve/request.pl | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 26e40dd685..61d56fd49d 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -663,19 +663,7 @@ foreach my $biblionumber (@biblionumbers) {
>             $reserve{'wbrcode'}       = $res->branchcode();
>             $reserve{'itemnumber'}    = $res->itemnumber();
>             $reserve{'wbrname'}       = $res->branch()->branchname();
>-
>-            if ( $reserve{'holdingbranch'} eq $reserve{'wbrcode'} ) {
>-
>-                # Just because the holdingbranch matches the reserve branch doesn't mean the item
>-                # has arrived at the destination, check for an open transfer for the item as well
>-                my ( $transfertwhen, $transfertfrom, $transferto ) =
>-                  C4::Circulation::GetTransfers( $res->itemnumber() );
>-                if ( not $transferto or $transferto ne $res->branchcode() ) {
>-                    $reserve{'atdestination'} = 1;
>-                }
>-            }
>-
>-            # set found to 1 if reserve is waiting for patron pickup
>+            $reserve{'atdestination'} = $res->is_at_destination();
>             $reserve{'found'}     = $res->is_found();
>             $reserve{'intransit'} = $res->is_in_transit();
>         }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12556: 107181 | 107182 | 107183 | 107184 | 107185 | 107186 | 108711 | 109140 | 109924 | 109925 | 109926 | 109927 | 109928 | 109929 | 110719 | 110942 | 110943 | 110944 | 110945 | 110946 | 110947 | 110948 | 110949 | 110950 | 110951 | 110952 | 110953 | 110954 | 110955 | 110956 | 110961 | 110962 | 110963 | 110964 | 110965 | 110966 | 111405 | 111406 | 111407 | 111408 | 111409 | 111410 | 111494 | 111495 | 111496 | 111497 | 111498 | 111499 | 111500 | 111509 | 111516 | 111585 | 111610