Attachment 107276 Details for Bug 26041 – Bug 26041: Remove readonly flag

[patch] Bug 26041: Remove readonly flag

Bug-26041-Remove-readonly-flag.patch (text/plain), 2.43 KB, created by Martin Renvoize (ashimema) on 2020-07-24 07:33:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-07-24 07:33:40 UTC

Size: 2.43 KB

patch

obsolete

>From 979ddbb039aae4fe0adbcec8db67698ba9adae7a Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 24 Jul 2020 08:30:27 +0100
>Subject: [PATCH] Bug 26041: Remove readonly flag
>
>This patch removes the readonly attribute from the date fields for
>'reserve suspension' on the holds table and in opac-user.
>
>Note: I could not find where the readonly attribute is added to the date
>fields used when places a reserver.
>
>Note: I'm not sure about this followup.. if you enter a date in the
>wrong format (American vs British for example) you might end up with a
>bad date being submitted which could either result in a nasty server
>error or the wrong date being used.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt     | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
>index 610c968649..fe9466ee80 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc
>@@ -206,7 +206,7 @@
> 
>                         [% IF AutoResumeSuspendedHolds %]
>                             <label for="suspend_until"> until </label>
>-                            <input type="text" name="suspend_until" id="suspend_until" class="suspend-until" readonly="readonly" size="10" />
>+                            <input type="text" name="suspend_until" id="suspend_until" class="suspend-until" size="10" />
>                             <a href="#" style="font-size:85%;text-decoration:none;" onclick="document.getElementById('suspend_until').value='';return false;">Clear date to suspend indefinitely</a>
>                         [% END %]
>                     </form>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 5e72d21891..4e8123822f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -785,7 +785,6 @@
>         $(document).ready(function(){
>             $('#opac-user-views').tabs();
>             $(".modal-nojs").addClass("modal").addClass("hide").removeClass("modal-nojs");
>-            $(".suspend-until").prop("readonly",1);
> 
>             $(".btn-delete-hold").on("click", function(e){
>                 e.preventDefault();
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26041: 107176 | 107274 | 107276 | 108664 | 109470 | 109544 | 109558