Attachment 107310 Details for Bug 25031 – Bug 25031: (follow-up) Fix markup error and restore cover class

[patch] Bug 25031: (follow-up) Fix markup error and restore cover class

Bug-25031-follow-up-Fix-markup-error-and-restore-c.patch (text/plain), 2.08 KB, created by Owen Leonard on 2020-07-24 11:22:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-07-24 11:22:52 UTC

Size: 2.08 KB

patch

obsolete

>From b5141881f2702571e7eea29b2ef0d44dcf18672a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 24 Jul 2020 11:19:24 +0000
>Subject: [PATCH] Bug 25031: (follow-up) Fix markup error and restore cover
> class
>
>This patch corrects a markup error that appears when no cover image
>services are enabled. An unclosed <div> caused links on the page to
>break.
>
>This patch also restores a part of the cover-handling script which adds
>a bordered style to the cover image "tiles"
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index d2376ab098..05c18f3ee2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -194,9 +194,11 @@
>                             <div class="hint">Custom cover image</div>
>                         </div>
>                     [% END %]
>-                </div>
>-            </div> 
>-        [% END %]
>+                </div> 
>+            </div> 
>+        [% ELSE %]
>+        </div> 
>+        [% END # /IF ( AmazonCoverImages, etc ) %]
> </div>
> <div id="bibliodetails" class="toptabs">
> 
>@@ -993,13 +995,15 @@ Note that permanent location is a code, and location may be an authval.
>                         $(covernav).addClass("nav-active");
>                     }
>                     $(covernav).html("<i class=\"fa fa-circle\"></i>");
>-                    $("#cover-slides").addClass("cover-slides").append( covernav );
>+                    $("#cover-slides").append( covernav );
> 
>                 });
>             }
> 
>             if( $(".cover-image:visible").length < 1 ){
>                 $("#cover-slides").remove();
>+            } else {
>+                $("#cover-slides").addClass("cover-slides");
>             }
> 
>             $("#editions img").each(function(i){
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25031: 102162 | 102295 | 103040 | 103079 | 105986 | 105987 | 106612 | 106613 | 107272 | 107310