Attachment 107316 Details for Bug 20256 – Bug 20256: Update groups editor

[patch] Bug 20256: Update groups editor

Bug-20256-Update-groups-editor.patch (text/plain), 9.37 KB, created by Kyle M Hall (khall) on 2020-07-24 11:35:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-07-24 11:35:14 UTC

Size: 9.37 KB

patch

obsolete

>From 37de8f6c235ed5bb4bb2879c30a6265a413888b7 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 28 Mar 2019 07:12:37 -0400
>Subject: [PATCH] Bug 20256: Update groups editor
>
>Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org>
>---
> admin/library_groups.pl                       |  4 +++
> .../prog/en/modules/admin/library_groups.tt   | 25 ++++++++++++++++---
> 2 files changed, 26 insertions(+), 3 deletions(-)
>
>diff --git a/admin/library_groups.pl b/admin/library_groups.pl
>index dcf71c87a3..fccdca7da2 100755
>--- a/admin/library_groups.pl
>+++ b/admin/library_groups.pl
>@@ -49,6 +49,7 @@ if ( $action eq 'add' ) {
>     my $description = $cgi->param('description') || undef;
>     my $branchcode  = $cgi->param('branchcode')  || undef;
>     my $ft_hide_patron_info    = $cgi->param('ft_hide_patron_info')    || 0;
>+    my $ft_limit_item_editing  = $cgi->param('ft_limit_item_editing')  || 0;
>     my $ft_search_groups_opac  = $cgi->param('ft_search_groups_opac')  || 0;
>     my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
>     my $ft_local_hold_group = $cgi->param('ft_local_hold_group') || 0;
>@@ -67,6 +68,7 @@ if ( $action eq 'add' ) {
>                     ft_search_groups_opac  => $ft_search_groups_opac,
>                     ft_search_groups_staff => $ft_search_groups_staff,
>                     ft_local_hold_group    => $ft_local_hold_group,
>+                    ft_limit_item_editing  => $ft_limit_item_editing,
>                     branchcode             => $branchcode,
>                 }
>             )->store();
>@@ -84,6 +86,7 @@ elsif ( $action eq 'edit' ) {
>     my $title       = $cgi->param('title')       || undef;
>     my $description = $cgi->param('description') || undef;
>     my $ft_hide_patron_info    = $cgi->param('ft_hide_patron_info')    || 0;
>+    my $ft_limit_item_editing  = $cgi->param('ft_limit_item_editing')  || 0;
>     my $ft_search_groups_opac  = $cgi->param('ft_search_groups_opac')  || 0;
>     my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
>     my $ft_local_hold_group = $cgi->param('ft_local_hold_group') || 0;
>@@ -96,6 +99,7 @@ elsif ( $action eq 'edit' ) {
>                 title       => $title,
>                 description => $description,
>                 ft_hide_patron_info      => $ft_hide_patron_info,
>+                ft_limit_item_editing    => $ft_limit_item_editing,
>                 ft_search_groups_opac    => $ft_search_groups_opac,
>                 ft_search_groups_staff   => $ft_search_groups_staff,
>                 ft_local_hold_group   => $ft_local_hold_group,
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>index edfe7b5ddc..c1d28273f8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>@@ -121,6 +121,12 @@
>                                         Limit patron data access by group
>                                     </label>
>                                 </p>
>+                                <p>
>+                                    <label>
>+                                        <input type="checkbox" name="ft_limit_item_editing" id="add-group-modal-ft_limit_item_editing" value="1" />
>+                                        Limit item editing by group
>+                                    </label>
>+                                </p>
>                                 <p>
>                                     <label>
>                                         <input type="checkbox" name="ft_search_groups_opac" id="add-group-modal-ft_search_groups_opac" value="1" />
>@@ -185,6 +191,12 @@
>                                         Limit patron data access by group
>                                     </label>
>                                 </p>
>+                                <p>
>+                                    <label>
>+                                        <input type="checkbox" id="edit-group-modal-ft_limit_item_editing" name="ft_limit_item_editing" value="1" />
>+                                        Limit item editing by group
>+                                    </label>
>+                                </p>
>                                 <p>
>                                     <label>
>                                         <input type="checkbox" id="edit-group-modal-ft_search_groups_opac" name="ft_search_groups_opac" value="1" />
>@@ -280,10 +292,11 @@
>                 var title = $(this).data('groupTitle');
>                 var description = $(this).data('groupDescription');
>                 var ft_hide_patron_info = $(this).data('groupFt_hide_patron_info');
>+                var ft_limit_item_editing = $(this).data('groupFt_limit_item_editing');
>                 var ft_search_groups_opac = $(this).data('groupFt_search_groups_opac');
>                 var ft_search_groups_staff = $(this).data('groupFt_search_groups_staff');
>                 var ft_local_hold_group = $(this).data('groupFt_local_hold_group');
>-                edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group );
>+                edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group, ft_limit_item_editing );
>             });
> 
>             $('.delete-group').on('click', function(e) {
>@@ -316,6 +329,7 @@
> 
> 
>             $('#add-group-modal-ft_hide_patron_info').prop('checked', false);
>+            $('#add-group-modal-ft_limit_item_editing').prop('checked', false);
>             $('#add-group-modal-ft_search_groups_opac').prop('checked', false);
>             $('#add-group-modal-ft_search_groups_staff').prop('checked', false);
>             $('#add-group-modal-ft_local_hold_group').prop('checked', false);
>@@ -328,19 +342,21 @@
> 
>         }
> 
>-        function edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group ) {
>+        function edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group, ft_limit_item_editing ) {
>             $('#edit-group-modal-id').val( id );
>             $('#edit-group-modal-title').val( title );
>             $('#edit-group-modal-description').val( description );
> 
>             if ( parent_id ) {
>                 $('#edit-group-modal-ft_hide_patron_info').prop('checked', false);
>+                $('#edit-group-modal-ft_limit_item_editing').prop('checked', false);
>                 $('#edit-group-modal-ft_search_groups_opac').prop('checked', false);
>                 $('#edit-group-modal-ft_search_groups_staff').prop('checked', false);
>                 $('#edit-group-modal-ft_local_hold_group').prop('checked', false);
>                 $('#root-group-features-edit').hide();
>             } else {
>                 $('#edit-group-modal-ft_hide_patron_info').prop('checked', ft_hide_patron_info ? true : false );
>+                $('#edit-group-modal-ft_limit_item_editing').prop('checked', ft_limit_item_editing ? true : false );
>                 $('#edit-group-modal-ft_search_groups_opac').prop('checked', ft_search_groups_opac ? true : false );
>                 $('#edit-group-modal-ft_search_groups_staff').prop('checked', ft_search_groups_staff ? true : false );
>                 $('#edit-group-modal-ft_local_hold_group').prop('checked', ft_local_hold_group ? true : false );
>@@ -390,6 +406,9 @@
>                 [% IF group.ft_hide_patron_info %]
>                     <li>Hide patron's info for librarians outside of this group.</li>
>                 [% END %]
>+                [% IF group.ft_limit_item_editing %]
>+                    <li>Limit item editing for librarians outside of this group.</li>
>+                [% END %]
>                 [% IF group.ft_search_groups_opac %]
>                     <li>Use for OPAC search groups</li>
>                 [% END %]
>@@ -416,7 +435,7 @@
>                        </li>
> 
>                         <li>
>-                            <a class="edit-group" id="edit-group-[% group.id | html %]" href="#" data-group-id="[% group.id | html %]" data-group-parent-id="[% group.parent_id | html %]" data-group-title="[% group.title | html %]" data-group-description="[% group.description | html %]" data-group-ft_hide_patron_info="[% group.ft_hide_patron_info | html %]" data-group-ft_search_groups_opac="[% group.ft_search_groups_opac | html %]" data-group-ft_search_groups_staff="[% group.ft_search_groups_staff | html %]" data-group-ft_local_hold_group="[% group.ft_local_hold_group | html %]" >
>+                            <a class="edit-group" id="edit-group-[% group.id | html %]" href="#" data-group-id="[% group.id | html %]" data-group-parent-id="[% group.parent_id | html %]" data-group-title="[% group.title | html %]" data-group-description="[% group.description | html %]" data-group-ft_hide_patron_info="[% group.ft_hide_patron_info | html %]" data-group-ft_search_groups_opac="[% group.ft_search_groups_opac | html %]" data-group-ft_search_groups_staff="[% group.ft_search_groups_staff | html %]" data-group-ft_local_hold_group="[% group.ft_local_hold_group | html %]" data-group-ft_limit_item_editing="[% group.ft_limit_item_editing | html %]" >
>                                 <i class="fa fa-pencil"></i> Edit
>                             </a>
>                        </li>
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 20256: 87226 | 87227 | 87228 | 87229 | 87230 | 87231 | 87232 | 87233 | 87262 | 87263 | 87264 | 87265 | 87266 | 87267 | 87268 | 87269 | 87270 | 88537 | 88539 | 88541 | 88542 | 88543 | 88544 | 88545 | 88546 | 88547 | 88632 | 88702 | 88703 | 88704 | 88705 | 88935 | 88936 | 96015 | 96016 | 96017 | 96018 | 96019 | 96020 | 96021 | 96022 | 96023 | 96024 | 96025 | 96026 | 96027 | 96028 | 96029 | 96030 | 96031 | 96032 | 96033 | 102622 | 102623 | 102624 | 102625 | 102626 | 102627 | 102628 | 102629 | 102630 | 102631 | 102632 | 102633 | 102634 | 102635 | 102636 | 102637 | 102638 | 102639 | 102640 | 102641 | 102642 | 102703 | 102704 | 102705 | 102706 | 102707 | 102708 | 102709 | 102710 | 102711 | 102712 | 102713 | 102714 | 102715 | 102716 | 102717 | 102718 | 102719 | 102720 | 102721 | 102722 | 102732 | 102733 | 102734 | 102735 | 102736 | 102737 | 102738 | 102739 | 102740 | 102741 | 102742 | 102743 | 102744 | 102745 | 102746 | 102747 | 102748 | 102749 | 102750 | 102751 | 107312 | 107313 | 107314 | 107315 | 107316 | 107317 | 107318 | 107319 | 107320 | 107321 | 107322 | 107323 | 107324 | 107325 | 107326 | 107327 | 107328 | 107329 | 107330 | 108851 | 108852 | 108853 | 108854 | 108855 | 108856 | 108857 | 108858 | 108859 | 108860 | 108861 | 108862 | 108863 | 108864 | 108865 | 108866 | 108867 | 108868 | 108869 | 108870 | 109939 | 110005 | 113706 | 113707 | 113708 | 113709 | 113710 | 113711 | 113712 | 113713 | 113714 | 113715 | 113716 | 113717 | 113718 | 113719 | 113720 | 113721 | 113722 | 113723 | 113724 | 113725 | 113726 | 113727 | 113728 | 116042 | 116043 | 116044 | 116045 | 116046 | 116047 | 116048 | 116049 | 116050 | 116051 | 116052 | 116053 | 116054 | 116055 | 116056 | 116057 | 116058 | 116059 | 116060 | 116061 | 116062 | 116063 | 116064 | 120055 | 120056 | 120057 | 120058 | 120059 | 120060 | 120061 | 120062 | 120063 | 120064 | 120065 | 120066 | 120067 | 120068 | 120069 | 120070 | 120071 | 120072 | 120073 | 120074 | 120075 | 120076 | 121771 | 121772 | 121773 | 121774 | 121775 | 121776 | 121777 | 121778 | 121779 | 121780 | 121781 | 121782 | 121783 | 121785 | 121786 | 121787 | 121788 | 121789 | 121790 | 121791 | 121792 | 124286 | 124287 | 124288 | 124289 | 124290 | 124291 | 124292 | 124293 | 124294 | 124295 | 124296 | 124297 | 124298 | 124299 | 124300 | 124301 | 124302 | 124303 | 124304 | 124305 | 124306 | 124307 | 124321 | 128734 | 128735 | 128736 | 128737 | 128738 | 128739 | 128740 | 128741 | 128742 | 128743 | 128744 | 128745 | 128746 | 128747 | 128748 | 128749 | 128750 | 128751 | 128752 | 128753 | 131676 | 131677 | 131678 | 131679 | 131680 | 131681 | 131682 | 131683 | 131684 | 131685 | 131686 | 131687 | 131688 | 131689 | 131690 | 131691 | 131692 | 131693 | 131694 | 131695 | 131696 | 131697 | 132483 | 132484 | 132486 | 132917 | 134375 | 134376 | 134377 | 139135 | 139136 | 139137 | 139138 | 139139 | 139140 | 139141 | 139142 | 139143 | 139144 | 139145 | 139146 | 139147 | 139148 | 139149 | 139150 | 139151 | 139152 | 139153 | 139154 | 139155 | 139156 | 139157 | 139158 | 139159 | 139160 | 139161 | 139162 | 139163 | 143527 | 143529 | 143530 | 143531 | 143532 | 143533 | 143534 | 143535 | 143536 | 143537 | 143538 | 143539 | 143540 | 143541 | 143542 | 143543 | 143544 | 143545 | 143546 | 143547 | 143548 | 143549 | 143550 | 143551 | 143552 | 143553 | 143554 | 143555 | 143556 | 145286 | 145287 | 145288 | 145289 | 145290 | 145291 | 145292 | 145293 | 145482 | 145483 | 145484 | 145485 | 145486 | 145487 | 145488 | 145489 | 145809 | 145810 | 145811 | 145812 | 145813 | 145814 | 145815 | 145816 | 145887 | 145888 | 145889 | 145890 | 145891 | 145892 | 145893 | 145894 | 145895 | 145896 | 145951 | 145952 | 145953 | 145954 | 145955