Bugzilla – Attachment 107351 Details for
Bug 24157
Additional acquisitions permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice
Bug-24157-follow-up-Conditionally-show-controls-to.patch (text/plain), 2.48 KB, created by
Alex Arnaud
on 2020-07-24 13:08:29 UTC
(
hide
)
Description:
Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2020-07-24 13:08:29 UTC
Size:
2.48 KB
patch
obsolete
>From 0da06f787fd04db5921bc59c212f45a649f34492 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 6 Mar 2020 19:13:35 +0000 >Subject: [PATCH] Bug 24157: (follow-up) Conditionally show controls to reopen > and close invoice > >This follow-up makes minor changes to the template so that the checkbox >for reopening or closing an invoice are not displayed when the user >doens't have the correct permissions. > >To test, apply the patch and try the process of viewing or editing an >invoice as a user with these various permissions: > > - edit_invoices ON > - edit_invoices OFF > - reopen_closed_invoices ON > - reopen_closed_invoices OFF > >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> >--- > .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 23 ++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index f710d384a0..c6f9fe2047 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -98,20 +98,23 @@ > <li><span class="label">Status:</span> > Closed on [% invoiceclosedate | $KohaDates %]</li> > >- <li> >- <label for="reopen">Reopen: </label> > [% IF CAN_user_acquisition_reopen_closed_invoices AND NOT readonly %] >- <input type="checkbox" name="reopen" id="reopen" /> >- [% ELSE %] >- <input type="checkbox" name="reopen" id="reopen" readonly="disabled" /> >+ <li> >+ <label for="reopen">Reopen: </label> >+ <input type="checkbox" name="reopen" id="reopen" /> >+ </li> > [% END %] >- </li> > [% ELSE %] >- <li><span class="label">Status:</span> >- Open</li> >- >- <li><label for="close">Close: </label> <input type="checkbox" name="close" id="close" /> >+ <li> >+ <span class="label">Status:</span> >+ Open >+ </li> >+ [% UNLESS ( readonly ) %] >+ <li> >+ <label for="close">Close: </label> >+ <input type="checkbox" name="close" id="close" /> > </li> >+ [% END %] > [% END %] > </ol> > [% UNLESS readonly %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24157
:
96274
|
96275
|
96276
|
96277
|
96278
|
98651
|
98652
|
98653
|
98654
|
98655
|
100283
|
100284
|
100285
|
100286
|
100287
|
100288
|
107132
|
107133
|
107134
|
107135
|
107136
|
107137
|
107138
|
107139
|
107309
|
107346
|
107347
|
107348
|
107349
|
107350
| 107351 |
107352
|
107353
|
107354