Attachment 107368 Details for Bug 26017 – Bug 26017: Correct permission check on tools page

[patch] Bug 26017: Correct permission check on tools page

Bug-26017-Correct-permission-check-on-tools-page.patch (text/plain), 1.89 KB, created by Katrin Fischer on 2020-07-25 08:27:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-07-25 08:27:16 UTC

Size: 1.89 KB

patch

obsolete

>From ab45bc02252f0b3eb0488edcada15a6d60ff6ea1 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 20 Jul 2020 09:40:00 +0100
>Subject: [PATCH] Bug 26017: Correct permission check on tools page
>
>The 'Cashup registers' link from the tools page retained an previous
>verions of the permission name. This patch corrects it to use the final
>name we sebtled on and thus now correctly displays the link when
>appropriate.
>
>Test plan
>1/ Enable cash registers via the 'UseCashRegisters' system preference
>2/ Ensure you are logged in as a user who has the cash management
>   cashup permission.
>3/ Verify that the 'Cashup registers' option appears on the tools page.
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>index ae4608c684..350fd1b28d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>@@ -135,11 +135,9 @@
>     <dd>Access files stored on the server, like log files or reports</dd>
>     [% END %]
> 
>-    [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) %]
>-        [% IF ( CAN_user_cash_management_manage_cash_registers ) %]
>+    [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_cashup ) %]
>         <dt><a href="/cgi-bin/koha/pos/registers.pl">Cashup registers</a></dt>
>-        <dd>Perfrom cashup actions on cash registers</dd>
>-        [% END %]
>+        <dd>Perform cashup actions on cash registers</dd>
>     [% END %]
> 
>     [% IF ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26017: 107080 | 107197 | 107368 | 107765 | 107766