Bugzilla – Attachment 107375 Details for
Bug 19261
Never hide biblionumber field in view policy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19261: Never hide biblionumber field in view policy
Bug-19261-Never-hide-biblionumber-field-in-view-po.patch (text/plain), 2.71 KB, created by
Katrin Fischer
on 2020-07-26 16:13:13 UTC
(
hide
)
Description:
Bug 19261: Never hide biblionumber field in view policy
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-07-26 16:13:13 UTC
Size:
2.71 KB
patch
obsolete
>From dfa0b3da252ea301702a970bbe86fc1fe46e620d Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 6 Sep 2017 13:44:41 +0200 >Subject: [PATCH] Bug 19261: Never hide biblionumber field in view policy >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Followed test plan and biblionumber subfield 999c is visible in OPAC irrespective of visibility now. >Patch applies and works as expected. > >Test plan: >0a) Use koha-testing-docker >0b) Do not apply patch >1) Hide 999$c in "Books, Booklets, Workbooks" framework >2) Search for "local-number:29 or local-number:30) >3) Note the search results include links like the following: >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=&searchid=scs_1595477248050 >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=&searchid=scs_1595477248050 >4) Apply the patch >5) restart_all >6) Search for "local-number:29 or local-number:30) >7) Note the search results include links like the following: >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29&searchid=scs_1595477625746 >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=30&searchid=scs_1595477625746 > >Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Filter/MARC/ViewPolicy.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/Koha/Filter/MARC/ViewPolicy.pm b/Koha/Filter/MARC/ViewPolicy.pm >index a963e3f129..3d12fab9eb 100644 >--- a/Koha/Filter/MARC/ViewPolicy.pm >+++ b/Koha/Filter/MARC/ViewPolicy.pm >@@ -127,7 +127,8 @@ sub _filter_field { > my $visibility = > $marcsubfieldstructure->{$tag}->{$subtag}->{hidden}; > $visibility //= 0; >- if ( $hide->{$interface}->{$visibility} ) { >+ my $kohafield = $marcsubfieldstructure->{$tag}->{$subtag}->{kohafield} // ''; >+ if ( $hide->{$interface}->{$visibility} && $kohafield ne 'biblio.biblionumber' ) { > > # deleting last subfield doesn't delete field, so > # this detects that case to delete the field. >@@ -147,7 +148,8 @@ sub _filter_field { > # -8 is flagged, and 9/-9 are not implemented. > my $visibility = $marcsubfieldstructure->{$tag}->{q{@}}->{hidden}; > $visibility //= 0; >- if ( $hide->{$interface}->{$visibility} ) { >+ my $kohafield = $marcsubfieldstructure->{$tag}->{q{@}}->{kohafield} // ''; >+ if ( $hide->{$interface}->{$visibility} && $kohafield ne 'biblio.biblionumber' ) { > $result->delete_fields($field); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19261
:
66870
|
66907
|
67444
|
107212
| 107375