Attachment 107405 Details for Bug 22417 – Bug 22417: Add the new permission manage_background_jobs

[patch] Bug 22417: Add the new permission manage_background_jobs

Bug-22417-Add-the-new-permission-managebackgroundj.patch (text/plain), 3.86 KB, created by Jonathan Druart on 2020-07-27 07:55:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-07-27 07:55:45 UTC

Size: 3.86 KB

patch

obsolete

>From 93ee87e185e8ee6acd122e5a02ea3a0ba51b1bc4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Jun 2020 12:48:00 +0200
>Subject: [PATCH] Bug 22417: Add the new permission manage_background_jobs
>
>QA: Please answer the question in admin/background_jobs.pl
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> admin/background_jobs.pl | 3 ++-
> installer/data/mysql/atomicupdate/bug_15032.perl | 6 ++++++
> installer/data/mysql/userpermissions.sql | 1 +
> koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 5 +++++
> 4 files changed, 14 insertions(+), 1 deletion(-)
>
>diff --git a/admin/background_jobs.pl b/admin/background_jobs.pl
>index 85dd740b40..9e08c70605 100755
>--- a/admin/background_jobs.pl
>+++ b/admin/background_jobs.pl
>@@ -37,7 +37,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> query => $input,
> type => "intranet",
> authnotrequired => 0,
>- flagsrequired => { parameters => 'manage_background_jobs' }, # TODO Add this new permission, so far only works for superlibrarians
>+ flagsrequired => { parameters => 'manage_background_jobs' }, # Maybe the "view" view should be accessible for the user who create this job.
>+ # But in that case what could the permission to check here? tools => '*' ?
> debug => 1,
> }
> );
>diff --git a/installer/data/mysql/atomicupdate/bug_15032.perl b/installer/data/mysql/atomicupdate/bug_15032.perl
>index 34554fc2f2..1c7eec4dbb 100644
>--- a/installer/data/mysql/atomicupdate/bug_15032.perl
>+++ b/installer/data/mysql/atomicupdate/bug_15032.perl
>@@ -20,6 +20,12 @@ if( CheckVersion( $DBversion ) ) {
> |);
> }
> 
>+ $dbh->do(qq{
>+ INSERT IGNORE permissions (module_bit, code, description)
>+ VALUES
>+ (3, 'manage_background_jobs', 'Manage background jobs')
>+ });
>+
> SetVersion( $DBversion );
> print "Upgrade to $DBversion done (Bug 15032 - Add new table background_jobs)\n";
> }
>diff --git a/installer/data/mysql/userpermissions.sql b/installer/data/mysql/userpermissions.sql
>index f90eee99a7..8b3fab0f93 100644
>--- a/installer/data/mysql/userpermissions.sql
>+++ b/installer/data/mysql/userpermissions.sql
>@@ -34,6 +34,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES
> ( 3, 'manage_mana', 'Manage Mana KB content sharing'),
> ( 3, 'manage_additional_fields', 'Add, edit, or delete additional custom fields for baskets or subscriptions (also requires order_manage or edit_subscription permissions)'),
> ( 3, 'manage_keyboard_shortcuts', 'Manage keyboard shortcuts for the advanced cataloging editor'),
>+ ( 3, 'manage_background_jobs', 'Manage background jobs'),
> ( 4, 'edit_borrowers', 'Add, modify and view patron information'),
> ( 4, 'view_borrower_infos_from_any_libraries', 'View patron infos from any libraries'),
> ( 6, 'place_holds', 'Place holds for patrons'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>index 368202b7cc..a2d3eb57aa 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>@@ -255,6 +255,11 @@
> Manage keyboard shortcuts for the advanced cataloging editor
> 
> ([% name | html %])
>+ [%- CASE 'manage_background_jobs' -%]
>+ 
>+ Manage background jobs
>+ 
>+ ([% name | html %])
> [%- CASE 'edit_borrowers' -%]
> 
> Add, modify and view patron information
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22417: 105542 | 105543 | 107385 | 107386 | 107387 | 107388 | 107389 | 107390 | 107391 | 107392 | 107393 | 107394 | 107395 | 107396 | 107397 | 107398 | 107399 | 107400 | 107401 | 107402 | 107403 | 107404 | 107405 | 107406 | 107481 | 107482 | 107682 | 108023 | 108024 | 108025 | 108026 | 108027 | 108028 | 108029 | 108030 | 108031 | 108032 | 108033 | 108034 | 108035 | 108036 | 108037 | 108038 | 108039 | 108040 | 108041 | 108042 | 108043 | 108044 | 108045 | 108046 | 108047 | 109270 | 109271 | 109319 | 109320 | 109321 | 109322 | 109323 | 109324 | 109325 | 109326 | 109327 | 109328 | 109329 | 109330 | 109331 | 109332 | 109333 | 109334 | 109335 | 109336 | 109337 | 109338 | 109339 | 109340 | 109341 | 109342 | 109343 | 109344 | 109345 | 109350 | 109351 | 109355 | 109390 | 109391 | 109392 | 109393 | 109394 | 109395 | 109396 | 109397 | 109398 | 109399 | 109400 | 109401 | 109402 | 109403 | 109404 | 109405 | 109406 | 109407 | 109408 | 109409 | 109410 | 109411 | 109412 | 109413 | 109414 | 109415 | 109416 | 109417 | 109418 | 109474 | 109475 | 109476 | 109477 | 110150 | 111091 | 111092 | 111093 | 111094 | 111095 | 111096 | 111097 | 111098 | 111099 | 111100 | 111101 | 111102 | 111103 | 111104 | 111105 | 111106 | 111107 | 111108 | 111109 | 111110 | 111111 | 111112 | 111113 | 111114 | 111115 | 111116 | 111117 | 111118 | 111119 | 111120 | 111121 | 111238 | 111239 | 111245