Attachment 107413 Details for Bug 20469 – Bug 20469: Add item status to staff article request form

[patch] Bug 20469: Add item status to staff article request form

Bug-20469-Add-item-status-to-staff-article-request.patch (text/plain), 4.30 KB, created by Marcel de Rooy on 2020-07-27 12:48:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-07-27 12:48:23 UTC

Size: 4.30 KB

patch

obsolete

>From c4f9f5713245b16a793a5053229e2e431ce0fbdf Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 26 Mar 2018 13:20:53 +0200
>Subject: [PATCH] Bug 20469: Add item status to staff article request form
>Content-Type: text/plain; charset=utf-8
>
>The template checks if an item is checked out, on hold (waiting or
>transit), not for loan. (Note: This can be extended in the future
>in a general include as we have at opac side.)
>
>Test plan:
>[1] Place an article request on an item on loan. Verify status on form.
>[2] Place an article request on a waiting item. Check status again.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>[EDIT] Simplified on 2020-07-27
>Removed Koha::Item->is_waiting_or_transit.
>Use Koha::Item->itemtype to check notforloan on itemtype level.
>Adjusted commit message accordingly.
>
>Additional test:
>[3] Place an article request on a not for loan item. Check status.
>
>NOTE: Not for loan is informational too. It does not say that this item
>is not available for an article request. Depends on local situation.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../intranet-tmpl/prog/en/modules/circ/article-requests.tt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
>index 10e69f48a4..79c9561d71 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
>@@ -42,6 +42,13 @@
> </ul>
> </div>
> [% END %]
>+[% BLOCK item_status %]
>+ [% IF myitem.onloan %]Checked out
>+ [% ELSIF myitem.holds({ found => ['W', 'T'] }).count > 0 %]On hold
>+ [% ELSIF myitem.notforloan > 0 OR myitem.itemtype({ effective => 1 }).notforloan %]Not for loan
>+ [% ELSIF myitem.notforloan < 0 %]On order
>+ [% END %]
>+[% END %]
> 
> <body id="circ_article-requests" class="circ">
> [% INCLUDE 'header.inc' %]
>@@ -107,6 +114,7 @@
> <th class="ar-collection">Collection</th>
> <th class="ar-itemtype">Item type</th>
> <th class="ar-callnumber">Call number</th>
>+ <th class="ar-status">Status</th>
> <th class="ar-copynumber">Copy number</th>
> <th class="ar-enumchron">Enumeration</th>
> <th class="ar-barcode">Barcode</th>
>@@ -176,6 +184,7 @@
> 
> [% ar.item.itemcallnumber | html %]
> </td>
>+ <td class="ar-status">[% PROCESS 'item_status' myitem = ar.item IF ar.item %]</td>
> <td class="ar-copynumber">[% ar.item.copynumber | html %]</td>
> <td class="ar-enumchron">[% ar.item.enumchron | html %]</td>
> <td class="ar-barcode">[% ar.item.barcode | html %]</td>
>@@ -212,6 +221,7 @@
> <th class="ar-collection">Collection</th>
> <th class="ar-itemtype">Item type</th>
> <th class="ar-callnumber">Call number</th>
>+ <th class="ar-status">Status</th>
> <th class="ar-copynumber">Copy number</th>
> <th class="ar-enumchron">Enumeration</th>
> <th class="ar-barcode">Barcode</th>
>@@ -281,6 +291,7 @@
> 
> [% ar.item.itemcallnumber | html %]
> </td>
>+ <td class="ar-status">[% PROCESS 'item_status' myitem = ar.item IF ar.item %]</td>
> <td class="ar-copynumber">[% ar.item.copynumber | html %]</td>
> <td class="ar-enumchron">[% ar.item.enumchron | html %]</td>
> <td class="ar-barcode">[% ar.item.barcode | html %]</td>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20469: 73281 | 73282 | 73388 | 76627 | 76628 | 76630 | 76631 | 77184 | 77185 | 77186 | 77222 | 77223 | 77224 | 107235 | 107236 | 107412 | 107413 | 107417 | 107418 | 107419 | 108345 | 108346 | 108347