Bugzilla – Attachment 107469 Details for
Bug 25946
borrowerRelationship can no longer be empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25946: borrowerRelationship can be empty
Bug-25946-borrowerRelationship-can-be-empty.patch (text/plain), 2.59 KB, created by
Peter Vashchuk
on 2020-07-28 15:24:41 UTC
(
hide
)
Description:
Bug 25946: borrowerRelationship can be empty
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2020-07-28 15:24:41 UTC
Size:
2.59 KB
patch
obsolete
>From 0016e1abde7d746b3b3a47eada7a49615baca16a Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Tue, 28 Jul 2020 18:22:50 +0300 >Subject: [PATCH] Bug 25946: borrowerRelationship can be empty > >When borrowerRelationship is empty in system preferences, Relationship >dropdown is not required and we accept empty value. > >Also fixes bug that didn't let you to pick empty value even when you >specified that it should be possible in system preferences but in the >end of the string (i.e. "|father|mother" worked, >but "father|mother|" don't). > >To reproduce (borrowerRelationship can be empty): > 1) Go to system preferences and make borrowerRelationship empty. > 2) Create a new patron who is assumed to have a guarantor or modify > the existing one. > 3) Under "Guarantor Information" click on "Search to add" button. > After performing the search, select a user to act as guarantor. Try to save your changes. > 4) Observe that relationship field is required in order to save but > you can't actually choose anything as it doesn't contain anything. > 5) Apply the patch. > 6) Repeat steps above. > 7) Observe that it allows you to save the form now. > >To reproduce (can't choose empty value bug): > 1) Go to system preferences and set borrowerRelationship exactly > to "father|mother|". > 2) Create a new patron who is assumed to have a guarantor or modify > the existing one. > 3) Under "Guarantor Information" click on "Search to add" button. > After performing the search, select a user to act as guarantor. > 4) Observe that there's no option to leave relationship field empty. > 5) Apply the patch. > 6) Repeat steps above. > 7) Observe that it has empty option that you can choose and save > the form. > >Mentored-by: Andrew Nugged <nugged@gmail.com> >--- > members/memberentry.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 985a96446c..9f478536b1 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -107,8 +107,8 @@ my @messages; > ## Deal with guarantor stuff > $template->param( relationships => scalar $patron->guarantor_relationships ) if $patron; > >-my @relations = split /,|\|/, C4::Context->preference('borrowerRelationship'); >-my $empty_relationship_allowed = grep {$_ eq ""} @relations; >+my @relations = split /,|\|/, C4::Context->preference('borrowerRelationship'), -1; >+my $empty_relationship_allowed = grep {$_ eq ""} (@relations || ''); > $template->param( empty_relationship_allowed => $empty_relationship_allowed ); > > my $guarantor_id = $input->param('guarantor_id'); >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25946
:
107469
|
108048
|
118991
|
118992
|
118993
|
118997
|
118998
|
118999
|
119011
|
119012
|
119013
|
119015